-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: type formatting #3618
Merged
Merged
chore: type formatting #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
requested changes
Nov 29, 2023
Co-authored-by: jfecher <jfecher11@gmail.com>
ghost
requested a review
from jfecher
November 29, 2023 15:07
jfecher
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
If possible, can you try to avoid force pushing in the future? It can be useful but also makes reviewing a bit more difficult after the first review since it prevents seeing only the commits that were added since the last review.
TomAFrench
added a commit
that referenced
this pull request
Nov 30, 2023
* master: chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625)
TomAFrench
added a commit
that referenced
this pull request
Nov 30, 2023
* master: (216 commits) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) fix: docker builds (#3620) feat: Copy on write optimization for brillig (#3522) chore: separate methods in `dc_crate` into their own modules (#3585) feat: add special case for boolean AND in acir-gen (#3615) chore: Update ACIR artifacts (#3614) chore: remove `get_number_sequence` foreign calls (#3613) feat: Add package version to Nargo.toml metadata (#3427) chore(docs): Links to Aztec docs from errors (#3423) ...
TomAFrench
added a commit
that referenced
this pull request
Dec 1, 2023
* master: (124 commits) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) ...
TomAFrench
added a commit
that referenced
this pull request
Dec 1, 2023
* master: (28 commits) feat: reuse witnesses more when interacting with memory (#3658) chore(ci): stop committing new acir artifacts (#3654) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.