Remove problematic test causing segfaults #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operators. This ended up with an unexpected situation of MRC operators and thus instances of PyFuncWrapper which were left orphaned and not destructed properly. This test wasn't testing much that wouldn't already be covered by our integration tests, and was causing segfaults elsewhere covered in issue 934
This reverts commit ed6a1b4.
This reverts commit ffcd5e6.
dagardner-nv
added
bug
mdemoret-nv
approved these changes
May 19, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pybind11link target tocudf_helpers_target. This was causing a build failure when MRC was pulled in via CPM but not when in the conda env.tests/test_appshield_source_stage.py::test_post_build_singlethis test wasn't very useful.PyFuncWrapperorphaned and not destructed at the end of the test.PyFuncWrapperinstances were destructed at the end of the test, but at times it would be destructed later on a thread which had already destructed otherPyFuncWrapperinstances and would trigger a an abort from within pybind11.fixes #934
Checklist