Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove problematic test causing segfaults #954

Merged
merged 9 commits into from
May 19, 2023
Merged

Remove problematic test causing segfaults #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ffcd5e6
Temp hard-code debug logging - DO NOT MERGE
dagardner-nv May 17, 2023
ed6a1b4
Temp testing - DO NOT MERGE
dagardner-nv May 17, 2023
c85b560
Add pybind to link targets, this is needed when MRC is pulled in via cpm
dagardner-nv May 18, 2023
030e807
Remove problematic test which mocked the MRC builder object, but not the
dagardner-nv May 19, 2023
b4718b2
Revert "Temp testing - DO NOT MERGE"
dagardner-nv May 19, 2023
e45f495
Revert "Temp hard-code debug logging - DO NOT MERGE"
dagardner-nv May 19, 2023
25b8ce9
Merge branch 'branch-23.07' into david-segfaults-934
dagardner-nv May 19, 2023
2aeb918
Remove unused import
dagardner-nv May 19, 2023
7c4e2f5
Merge branch 'david-segfaults-934' of github.com:dagardner-nv/Morpheu…
dagardner-nv May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions morpheus/_lib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ morpheus_add_cython_library(
"include"
LINK_TARGETS
cudf::cudf
pybind11::pybind11
Python::Module
Python::NumPy
OUTPUT_TARGET
Expand Down
52 changes: 0 additions & 52 deletions tests/test_appshield_source_stage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import glob
import json
import os
from unittest import mock

import pandas as pd
import pytest
Expand Down Expand Up @@ -311,54 +310,3 @@ def test_build_metadata(input_df_per_source):

assert len(appshield_message_metas) == 2
assert isinstance(appshield_message_metas[0], AppShieldMessageMeta)


@pytest.mark.use_python
@pytest.mark.parametrize('cols_include',
[[
'Base',
'Block',
'CommitCharge',
'End VPN',
'File',
'GrantedAccess',
'HandleValue',
'InInit',
'InLoad',
'InMem',
'Name',
'Offset',
'PID',
'Parent',
'Path',
'PrivateMemory',
'Process',
'Protection',
'SHA256',
'Size',
'Start VPN',
'State',
'TID',
'Tag',
'Type',
'Value',
'Variable',
'WaitReason',
'plugin',
'snapshot_id',
'timestamp'
]])
@pytest.mark.parametrize('cols_exclude', [['SHA256']])
@pytest.mark.parametrize('plugins_include', [['ldrmodules', 'threadlist', 'envars', 'vadinfo', 'handles']])
@pytest.mark.parametrize('input_glob', [os.path.join(TEST_DIRS.tests_data_dir, 'appshield', 'snapshot-1', '*.json')])
def test_post_build_single(config, input_glob, cols_include, cols_exclude, plugins_include):
mock_stream = mock.MagicMock()
mock_segment = mock.MagicMock()
mock_segment.make_node.return_value = mock_stream
mock_input = mock.MagicMock()

source = AppShieldSourceStage(config, input_glob, plugins_include, cols_include, cols_exclude)
source._post_build_single(mock_segment, mock_input)

mock_segment.make_node.assert_called_once()
mock_segment.make_edge.assert_called_once()