Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove problematic test causing segfaults #954

Merged
merged 9 commits into from
May 19, 2023
Merged

Remove problematic test causing segfaults #954

merged 9 commits into from
May 19, 2023

Commits on May 17, 2023

  1. Temp hard-code debug logging - DO NOT MERGE

    @dagardner-nv
    dagardner-nv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    ffcd5e6 View commit details
    Browse the repository at this point in the history

  2. Temp testing - DO NOT MERGE

    @dagardner-nv
    dagardner-nv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    ed6a1b4 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Add pybind to link targets, this is needed when MRC is pulled in via cpm

    @dagardner-nv
    dagardner-nv committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c85b560 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Remove problematic test which mocked the MRC builder object, but not the 

    operators. This ended up with an unexpected situation of MRC operators and
thus instances of PyFuncWrapper which were left orphaned and not destructed
properly.

This test wasn't testing much that wouldn't already be covered by our
integration tests, and was causing segfaults elsewhere covered in
issue 934
    @dagardner-nv
    dagardner-nv committed May 19, 2023
    Configuration menu
    Copy the full SHA
    030e807 View commit details
    Browse the repository at this point in the history

  2. Revert "Temp testing - DO NOT MERGE" 

    This reverts commit ed6a1b4.
    @dagardner-nv
    dagardner-nv committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b4718b2 View commit details
    Browse the repository at this point in the history

  3. Revert "Temp hard-code debug logging - DO NOT MERGE" 

    This reverts commit ffcd5e6.
    @dagardner-nv
    dagardner-nv committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e45f495 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-23.07' into david-segfaults-934

    @dagardner-nv
    dagardner-nv authored May 19, 2023
    Configuration menu
    Copy the full SHA
    25b8ce9 View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @dagardner-nv
    dagardner-nv committed May 19, 2023
    Configuration menu
    Copy the full SHA
    2aeb918 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'david-segfaults-934' of github.com:dagardner-nv/Morpheu… 

    …s into david-segfaults-934
    @dagardner-nv
    dagardner-nv committed May 19, 2023
    Configuration menu
    Copy the full SHA
    7c4e2f5 View commit details
    Browse the repository at this point in the history