Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations #17137

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Update translations #17137

merged 2 commits into from
Sep 9, 2024

Conversation

SaschaCowley
Copy link
Member

@SaschaCowley SaschaCowley commented Sep 9, 2024

Summary by CodeRabbit

  • New Features

    • Added new braille table entries for "Greek international braille (2-cell accented letters)" and "Greek international braille (single-cell accented letters)" across multiple languages.
  • Bug Fixes

    • Updated terminology for clarity, changing "old source text" to "previous source text" and "translation warning" to "translation issue" in various contexts.
  • Documentation

    • Updated metadata fields, including "POT-Creation-Date" and "PO-Revision-Date," to reflect recent changes across localization files.

These changes enhance the overall user experience by improving the accuracy and clarity of translations in NVDA.

@SaschaCowley SaschaCowley requested a review from a team as a code owner September 9, 2024 00:27
Copy link
Contributor

coderabbitai bot commented Sep 9, 2024

Walkthrough

The pull request includes significant updates across multiple localization files for the NVDA screen reader. Key changes involve the addition and renaming of braille table entries to provide more precise descriptions, such as specifying types of Greek international braille. Metadata updates reflect new timestamps, and terminology has been standardized, including changes from "old source text" to "previous source text" and "translation warning" to "translation issue." These modifications enhance the clarity and accuracy of translations across various languages.

Changes

Files Change Summary
source/locale/af_ZA/LC_MESSAGES/nvda.po, source/locale/am/LC_MESSAGES/nvda.po, source/locale/an/LC_MESSAGES/nvda.po, source/locale/ar/LC_MESSAGES/nvda.po, source/locale/bg/LC_MESSAGES/nvda.po, source/locale/bn/LC_MESSAGES/nvda.po, source/locale/ca/LC_MESSAGES/nvda.po, source/locale/ckb/LC_MESSAGES/nvda.po, source/locale/cs/LC_MESSAGES/nvda.po, source/locale/da/LC_MESSAGES/nvda.po, source/locale/de/LC_MESSAGES/nvda.po, source/locale/de_CH/LC_MESSAGES/nvda.po, source/locale/el/LC_MESSAGES/nvda.po, source/locale/es/LC_MESSAGES/nvda.po, source/locale/es_CO/LC_MESSAGES/nvda.po, source/locale/fa/LC_MESSAGES/nvda.po, source/locale/fi/LC_MESSAGES/nvda.po, source/locale/fr/LC_MESSAGES/nvda.po, source/locale/ga/LC_MESSAGES/nvda.po Updates to translation strings, including additions and renaming of braille table entries for clarity. Metadata timestamps updated. Changes in terminology from "old source text" to "previous source text" and "translation warning" to "translation issue." Enhancements across various languages.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Outside diff range, codebase verification and nitpick comments (1)
source/locale/de_CH/LC_MESSAGES/nvda.po (1)

5-6: Inconsistency in PO-Revision-Date

The PO-Revision-Date ("2024-09-09 00:08") is earlier than the last commit date ("Mon Sep 9 10:26:50 2024 +1000"). Please update the PO-Revision-Date to reflect the most recent changes accurately.

  • File: source/locale/de_CH/LC_MESSAGES/nvda.po
  • Lines: 5-6
Analysis chain

Metadata Update: Check for consistency and accuracy.

The metadata for POT-Creation-Date and PO-Revision-Date has been updated. Ensure that these timestamps accurately reflect the most recent updates and are consistent with the project's version control timestamps.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the consistency of metadata timestamps with version control.

# Test: Retrieve the last commit date for the file and compare with the PO-Revision-Date.
git log -1 --format=%cd -- source/locale/de_CH/LC_MESSAGES/nvda.po

Length of output: 98

source/locale/da/LC_MESSAGES/nvda.po Show resolved Hide resolved
source/locale/da/LC_MESSAGES/nvda.po Show resolved Hide resolved
source/locale/bg/LC_MESSAGES/nvda.po Show resolved Hide resolved
source/locale/es/LC_MESSAGES/nvda.po Show resolved Hide resolved
source/locale/es/LC_MESSAGES/nvda.po Show resolved Hide resolved
source/locale/es/LC_MESSAGES/nvda.po Show resolved Hide resolved
@seanbudd
Copy link
Member

seanbudd commented Sep 9, 2024

@coderabbitai resolve

@AppVeyorBot
Copy link

See test results for failed build of commit 9a79f2dcd8

@seanbudd seanbudd merged commit 10b4403 into beta Sep 9, 2024
5 checks passed
@seanbudd seanbudd deleted the updateTranslations branch September 9, 2024 04:13
@github-actions github-actions bot added this to the 2025.1 milestone Sep 9, 2024
@coderabbitai coderabbitai bot mentioned this pull request Sep 9, 2024
@SaschaCowley SaschaCowley modified the milestones: 2025.1, 2024.4 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants