Beta to master #17140
Merged
Beta to master #17140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from Crowdin (#17106) This pr adds a newly generated changes.xliff for English, which has also been uploaded to Crowdin. This PR updates the user docs github action to upload the English changes.xliff to Crowdin if it has changed. This pr also includes the initial set of translated user docs xliff files from Crowdin. So far that is 20 translations of the user guide, and 7 translations of changes (what's new). scons will see that these are newer than their markdown files, and rebuild the markdown files from these, and then build the html from the rebuilt markdown files.
Summary of the issue: Liblouis 3.31 has been released. Among new tables, this release contains a bug fix for Spanish causing digits to be presented incorrectly, see liblouis/liblouis#1624. Description of user facing changes Update to Liblouis 3.31, adding new tables as mentioned in the changelog. Description of development approach Update the submodule, added and updated definitions in brailleTables.py
Summary of the issue: In Albatross driver, a string consisting in the concatenation of normal strings (`"..."`) and an f-string) is passed to the `_` translation function. As a consequence: * Only a part of the concatenated string appears in the `.pot` file instead of the full concatenation * In any case, f-strings cannot be used for translatable messages since the formatting should be applied only after the gettext function has been called Thus, this message was not translated. Description of user facing changes The message of the Albatross driver is now translated. Description of development approach Do not use f-string. Instead used `.format` function, applied to the translated string. Slightly reworded the returned message for clarity. Testing strategy: - Check in the `.pot` file that we have the full message Known issues with pull request: None
Fixes #17026 Summary of the issue: Trying to compile NVDA with Visual Studio 2022 V17.11 produces the following error: build\x86\local\beeps.cpp(19): error C2039: 'min': is not a member of 'std' std::min and std::max are defined in <algorithm> which we never include in beeps.cpp. I assume that <cmath> used to include <algorithm> and now it does not. Description of user facing changes None. Description of development approach Include <algorithm> in beeps.cpp.
RC to beta
Update translations
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces several updates across various files, including enhancements to the workflow for uploading translation files to Crowdin, modifications to the Changes
Possibly related issues
Possibly related PRs
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This merge overwrote the 2025.1 changelog: when I look at "what's new" on the latest |
|
I see it just fine here: https://github.com/nvaccess/nvda/blob/master/user_docs/en/changes.md |
|
The generated artefact isn't... |
|
@codeofdusk - I believe that's because we are using the xliff data from beta to generate html files now. @michaelDCurran - can you please confirm this is expected? |
|
Hmm. That should be true for all languages other than English.
For English it should not generate intermediate markdown from its xliff
for building the html. Rather It should just use the markdown file that
was there.
I'll look into this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
liblouisdependency.