feat: add resource transfer logic to support different ACL strategy #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2023
This was referenced Apr 3, 2023
gabrielfs7
commented
Apr 6, 2023
|
|
||
| public function __construct(ClassCopierInterface $taoClassCopier) | ||
| public function __construct(ClassCopierInterface $taoClassCopier, Ontology $ontology) |
There was a problem hiding this comment.
- Use only ResourceTransferInterface instead
gabrielfs7
commented
Apr 6, 2023
gabrielfs7
commented
Apr 6, 2023
composer.json
Outdated
| @@ -67,7 +67,7 @@ | |||
| "require": { | |||
| "oat-sa/oatbox-extension-installer": "~1.1||dev-master", | |||
| "oat-sa/generis": ">=15.22", | |||
| "oat-sa/tao-core": ">=50.26.0", | |||
| "oat-sa/tao-core": "dev-feat/RFE-530/integration-branch as 52.0", | |||
There was a problem hiding this comment.
- Use proper version after release
shpran
force-pushed
the
feat/RFE-530/integration-branch
branch
4 times, most recently
from
b6c7ccb to
947c95f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #607 +/- ##
=============================================
+ Coverage 14.64% 15.72% +1.08%
Complexity 553 553
=============================================
Files 50 49 -1
Lines 1530 1666 +136
=============================================
+ Hits 224 262 +38
- Misses 1306 1404 +98
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hectoras
reviewed
Apr 12, 2023
composer.json
Outdated
| "oat-sa/generis": ">=15.22", | ||
| "oat-sa/tao-core": ">=50.26.0", | ||
| "oat-sa/generis": ">=15.23", | ||
| "oat-sa/tao-core": "dev-feat/RFE-530/integration-branch as v52.0.0", |
There was a problem hiding this comment.
- Don't forget to update this :)
hectoras
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- New code is covered by tests (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- Acceptance criteria are respected
- Kitchen links are not exposed in the description
- Run composer locally is working
- Updated instance with old composer works
- No unnecessary dependencies are installed
- All required dependencies were installed or updated
- Target branch is correct
- Change log provided
shpran
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/RFE-530
https://oat-sa.atlassian.net/browse/ADF-1424
https://oat-sa.atlassian.net/browse/ADF-1425
https://oat-sa.atlassian.net/browse/ADF-1426
https://oat-sa.atlassian.net/browse/ADF-1427
Goal
Add dynamic ACL strategy to
Move toandCopy tofeaturesHow to test
Related PRs