chore: add missing dependencies for ACL strategy copy #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #462 +/- ##
=============================================
+ Coverage 33.15% 34.60% +1.44%
Complexity 768 768
=============================================
Files 98 93 -5
Lines 2856 2734 -122
=============================================
- Hits 947 946 -1
+ Misses 1909 1788 -121
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Apr 3, 2023
gabrielfs7
commented
Apr 6, 2023
gabrielfs7
commented
Apr 6, 2023
composer.json
Outdated
Comment on lines
30
to
33
| "oat-sa/tao-core": "dev-feat/RFE-530/integration-branch as 52.0", | ||
| "oat-sa/extension-tao-item": "dev-feat/RFE-530/integration-branch as 12.0", | ||
| "oat-sa/extension-tao-itemqti": ">=29.14.5", | ||
| "oat-sa/extension-tao-test": ">=15.0.0", | ||
| "oat-sa/extension-tao-test": "dev-feat/RFE-530/integration-branch as 16.0", |
There was a problem hiding this comment.
- Use proper versions before release
hectoras
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Target branch is correct
- Change log provided
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- Acceptance criteria are respected
- Kitchen links are not exposed in the description
- No unnecessary dependencies are installed
- All required dependencies were installed or updated
shpran
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/RFE-530
https://oat-sa.atlassian.net/browse/ADF-1424
https://oat-sa.atlassian.net/browse/ADF-1425
https://oat-sa.atlassian.net/browse/ADF-1426
https://oat-sa.atlassian.net/browse/ADF-1427
Goal
Add dynamic ACL strategy to
Move toandCopy tofeaturesHow to test
Related PRs