-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add comment to track actions and common command object #3776
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3776 +/- ##
=============================================
+ Coverage 27.48% 28.12% +0.63%
- Complexity 10794 10881 +87
=============================================
Files 903 915 +12
Lines 32202 32655 +453
=============================================
+ Hits 8852 9183 +331
- Misses 23350 23472 +122
|
…ao-core into feat/RFE-530/integration-branch
/** @var LoggerInterface|MockObject */ | ||
private LoggerInterface $logger; | ||
|
||
protected function setUp(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are declaring the property for the subject under test dynamically on line 87, but I'd be better to declare it explicitly here.
/** @var LoggerInterface|MockObject */ | |
private LoggerInterface $logger; | |
protected function setUp(): void | |
/** @var LoggerInterface|MockObject */ | |
private LoggerInterface $logger; | |
private ClientConfigStorage $sut; | |
protected function setUp(): void |
$query | ||
->method('getShownStructure') | ||
->willReturn('shownStructure'); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remember to extend this test or call
markTestIncomplete()
$query | |
->method('getShownStructure') | |
->willReturn('shownStructure'); | |
} | |
} | |
$query | |
->method('getShownStructure') | |
->willReturn('shownStructure'); | |
$this->markTestIncomplete(); | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is in progress yet by @shpran . We should test at least the happy path here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, makes sense 👌 sorry for the noise
|
||
public function setConfigByPath(array $path): void | ||
{ | ||
$this->config = array_merge_recursive($this->config, $path); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function setConfigByPath(array $path): void | |
{ | |
$this->config = array_merge_recursive($this->config, $path); | |
} | |
public function setConfigByPath(array $path): void | |
{ | |
$this->config = array_merge_recursive($this->config, $path); | |
} |
@@ -7,6 +7,7 @@ tao-core | |||
- [Middlewares Doc](models/classes/Middleware/README.md) | |||
- [Feature Flag](models/classes/featureFlag/README.md) | |||
- [CSRF Tokens](models/classes/security/xsrf/README.md) | |||
- [Client Config](models/classes/clientConfig/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks @shpran
This reverts commit d0346cb.
a8efd58
to
4811cb2
Compare
…front-end-permissions-radio-buttons
…ssions-radio-buttons Feature/adf 1424/front end permissions radio buttons
Version
There are 0 BREAKING CHANGE, 11 features, 9 fixes |
https://oat-sa.atlassian.net/browse/RFE-530
https://oat-sa.atlassian.net/browse/ADF-1424
https://oat-sa.atlassian.net/browse/ADF-1425
https://oat-sa.atlassian.net/browse/ADF-1426
https://oat-sa.atlassian.net/browse/ADF-1427
Goal
Add dynamic ACL strategy to
Move to
andCopy to
featuresHow to test
Related PRs