Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into BLST feature branch #4863

Merged
merged 2,056 commits into from
Nov 24, 2023

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Oct 23, 2023

This is to pull in changes to reduce the quantity of network-layer metrics, which previously was causing large BN2 instances to hit Grafana limits.

List of files with conflicts

CONFLICT (modify/delete): .github/workflows/bench.yml deleted in master and modified in HEAD. Version HEAD of .github/workflows/bench.yml left in tree.
CONFLICT (content): Merge conflict in .github/workflows/ci.yml
CONFLICT (content): Merge conflict in Makefile
CONFLICT (content): Merge conflict in integration/Makefile
CONFLICT (content): Merge conflict in integration/tests/epochs/cohort2/epoch_join_and_leave_vn_test.go

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 197 lines in your changes are missing coverage. Please review.

Comparison is base (ab78dbb) 54.65% compared to head (c990e22) 56.26%.
Report is 1049 commits behind head on feature/blst-based-crypto.

Files Patch % Lines
cmd/scaffold.go 14.28% 102 Missing ⚠️
cmd/execution_builder.go 0.00% 63 Missing ⚠️
cmd/verification_builder.go 0.00% 13 Missing ⚠️
cmd/bootstrap/run/execution_state.go 47.82% 8 Missing and 4 partials ⚠️
cmd/execution_config.go 0.00% 5 Missing ⚠️
config/config.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/blst-based-crypto    #4863      +/-   ##
=============================================================
+ Coverage                      54.65%   56.26%   +1.60%     
=============================================================
  Files                            917      974      +57     
  Lines                          85507    90879    +5372     
=============================================================
+ Hits                           46734    51131    +4397     
- Misses                         35184    35934     +750     
- Partials                        3589     3814     +225     
Flag Coverage Δ
unittests 56.26% <16.17%> (+1.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby removed the request for review from yhassanzadeh13 October 24, 2023 17:32
@tarakby tarakby self-assigned this Oct 24, 2023
zhangchiqing and others added 28 commits November 22, 2023 10:18
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Move stale issue bot workflow to worflow dir
Update Responsible Disclosure Link
[Storehouse] Execution State - Update IsBlockExecuted
…coding

[Access] Update websockets event streaming to return JSON-CDC encoded events
@tarakby tarakby merged commit 91f529c into feature/blst-based-crypto Nov 24, 2023
52 of 53 checks passed
@tarakby tarakby deleted the jordan/merge-master-blst branch November 24, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.