Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support training of BEVFusion #2558

Merged

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12 JingweiZhang12 force-pushed the bevfusion_oldsweep_fixpos branch from 121bb8e to e57a820 Compare May 26, 2023 06:51
@JingweiZhang12 JingweiZhang12 force-pushed the bevfusion_oldsweep_fixpos branch from e57a820 to 5fee2e0 Compare May 26, 2023 07:50
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 65.00% and project coverage change: +0.01 🎉

Comparison is base (fa724b1) 46.90% compared to head (a2328ee) 46.91%.

❗ Current head a2328ee differs from pull request most recent head e127201. Consider uploading reports for the commit e127201 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2558      +/-   ##
===========================================
+ Coverage    46.90%   46.91%   +0.01%     
===========================================
  Files          277      277              
  Lines        23378    23381       +3     
  Branches      3644     3644              
===========================================
+ Hits         10965    10969       +4     
+ Misses       11721    11719       -2     
- Partials       692      693       +1     
Flag Coverage Δ
unittests 46.91% <65.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/data_preprocessors/utils.py 22.72% <50.00%> (+3.67%) ⬆️
mmdet3d/engine/hooks/disable_object_sample_hook.py 84.37% <60.00%> (-4.92%) ⬇️
...t3d/models/data_preprocessors/data_preprocessor.py 31.91% <72.72%> (+0.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 merged commit 583e907 into open-mmlab:dev-1.x May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants