Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

sometimes trace_filter returns empty array whilst in fact there is a transaction matching the filter #7228

Closed
gituser opened this issue Dec 6, 2017 · 11 comments · Fixed by #7979
Labels
F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@gituser
Copy link

gituser commented Dec 6, 2017

I'm running:

*Which Parity version?**: 1.7.8
Which operating system?: Linux
How installed?: from source
Are you fully synchronized?: yes
Did you try to restart the node?: yes

I'm running Parity/v1.7.8-unstable-d5fcf3b-20171025/x86_64-linux-gnu/rustc1.19.0 self-compiled with options /home/ethereum/parity --author xxx --chain=frontier --mode=active --mode-timeout 10 --mode-alarm 30 --cache-size 10240 -l 3 --datadir /home/ethereum/.parity --port xxx --min-peers 50 --max-peers 100 --jsonrpc-interface x.x.x.x --jsonrpc-port xxxx --ipc-apis web3,eth,net,personal,traces,rpc,parity,parity_set,parity_accounts --jsonrpc-apis web3,eth,net,personal,traces,rpc,parity,parity_set,parity_accounts --ipc-path /home/ethereum/.parity/parity.ipc --db-path /home/ethereum/.parity --keys-path /home/ethereum/.parity/keys --dapps-path /home/ethereum/.parity/dapps --no-ui --no-dapps --allow-ips=public --pruning-history 1024 --tracing on

Sometimes trace_filter returns array(0) {} when in fact there is a transaction matching that address.

Strangely enough I've tried trace_filter on another node with the exact same version and exact same options (as I posted above) and it works there!

What could be the reason and how to fix if possible?

Both nodes ofc are synced to the top of the blockchain.

@5chdn 5chdn added F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon. labels Dec 8, 2017
@5chdn
Copy link
Contributor

5chdn commented Dec 8, 2017

related #7211

@gituser
Copy link
Author

gituser commented Dec 8, 2017

Thanks for the acknowledgement. Would be nice to fix this issue ASAP if possible.

@5chdn 5chdn added this to the 1.9 milestone Jan 5, 2018
@5chdn 5chdn modified the milestones: 1.9, 1.10 Jan 23, 2018
@gituser
Copy link
Author

gituser commented Jan 25, 2018

still no update on this? running v1.8.6 and still the same bug

maybe there is some workaround exists?

@gituser
Copy link
Author

gituser commented Feb 20, 2018

5 more releases and still no fix for this?

@5chdn
Copy link
Contributor

5chdn commented Feb 21, 2018

Pull requests welcome :)

If you know Rust developers with some free time, feel free to send them my way. Any help appreciated!

@gituser
Copy link
Author

gituser commented Feb 21, 2018

What happened with all your parity developers?

I'm not good in Rust, so unfortunately can't fix the issue myself.

@5chdn
Copy link
Contributor

5chdn commented Feb 21, 2018

They are busy hacking polkadot, parity-wasm, rust-libp2p, parity-bridge, etc. pp. We need more hands on the Ethereum client.

@gituser
Copy link
Author

gituser commented Feb 21, 2018

They are busy hacking polkadot, parity-wasm, rust-libp2p, parity-bridge, etc. pp. We need more hands on the Ethereum client.

do you mean that frozen contract? is there anything possible to do with it except forking?

parity was always the leading client in terms of performance but now starting to fall back again due many bugs (e.g. losing peers from time to time - the only workaround i've found is to stop node, remove nodes.json and start it again so it syncs again) and this bug with tracing is quite annoying as well.

would be nice to pick up the focus back on parity as it's a core software from you guys imo.

thanks.

@5chdn
Copy link
Contributor

5chdn commented Feb 22, 2018

parity was always the leading client in terms of performance but now starting to fall back again due many bugs

Yes, indeed, nobody is more aware than I am.

5chdn pushed a commit that referenced this issue Feb 28, 2018
* Hardware-wallet/usb-subscribe-refactor (#7860)

* Hardware-wallet fix

* More fine-grained initilization of callbacks by vendorID, productID and usb class
* Each device manufacturer gets a seperate handle thread each
* Replaced "dummy for loop" with a delay to wait for the device to boot-up properly
* Haven't been very carefully with checking dependencies cycles etc
* Inline comments explaining where shortcuts have been taken
* Need to test this on Windows machine and with Ledger (both models)

Signed-off-by: niklasad1 <niklasadolfsson1@gmail.com>

* Validate product_id of detected ledger devices

* closed_device => unlocked_device

* address comments

* add target in debug

* Address feedback

* Remove thread joining in HardwareWalletManager
* Remove thread handlers in HardwareWalletManager because this makes them unused

* fixed broken logs (#7934)

* fixed broken logs

* bring back old lock order

* removed bloom groups from blockchain

* revert unrelated changes

* simplify blockchain_block_blooms

* Bump WS (#7952)

* Calculate proper keccak256/sha3 using parity. (#7953)

* Increase max download limit to 128MB (#7965)

* fetch: increase max download limit to 64MB

* parity: increase download size limit for updater service

* Detect too large packets in snapshot sync. (#7977)

* fix traces, removed bloomchain crate, closes #7228, closes #7167 (#7979)

* Remvoe generator.rs

* Make block generator easier to use (#7888)

* Make block generator easier to use

* applied review suggestions

* rename BlockMetadata -> BlockOptions

* removed redundant uses of blockchain generator and genereator.next().unwrap() calls
debris added a commit that referenced this issue Mar 6, 2018
@gituser
Copy link
Author

gituser commented Mar 7, 2018

I guess the fix has only been applied to 1.9.4 ?

1.9.4 version Parity/v1.9.4-unstable-6f21a32-20180228/x86_64-linux-gnu/rustc1.24.1) is failing for me right now on testnet: #7999 (comment)

andresilva pushed a commit that referenced this issue Mar 12, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
andresilva pushed a commit that referenced this issue Mar 16, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
tomusdrw pushed a commit that referenced this issue Mar 16, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
debris pushed a commit that referenced this issue Mar 19, 2018
* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* add some dos protection (#8084)

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* Fix compilation.

* Check one step deeper if we're on release track branches

* add missing pr

* Fix blooms?

* Fix tests compiilation.

* Fix size.
andresilva pushed a commit that referenced this issue Mar 19, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
tomusdrw pushed a commit that referenced this issue Mar 19, 2018
* Support parity protocol. (#8035)

* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* WASM libraries bump (#7970)

* update wasmi, parity-wasm, wasm-utils to latest version

* Update to new wasmi & error handling

* also utilize new stack limiter

* fix typo

* replace dependency url

* Cargo.lock update

* add some dos protection (#8084)

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* fix trace filter returning returning unrelated reward calls, closes #8070 (#8098)

* network: init discovery using healthy nodes (#8061)

* network: init discovery using healthy nodes

* network: fix style grumble

* network: fix typo

* Postpone Kovan hard fork (#8137)

* ethcore: postpone Kovan hard fork

* util: update version fork metadata

* Disable UI by default. (#8105)

* dapps: update parity-ui dependencies (#8160)
@gituser
Copy link
Author

gituser commented Apr 19, 2018

So, just to re-iterate, to get this issue fixed you need:

  • latest version of parity 1.9.6 (right now)
  • full re-sync of the blockchain with tracing=On

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants