Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Postpone Kovan hard fork #8137

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Postpone Kovan hard fork #8137

merged 2 commits into from
Mar 19, 2018

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Mar 16, 2018

❯ date -d "+$(( (6600000 - 6389810) * 4 )) seconds"
Mon Mar 26 10:45:53 WEST 2018

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 16, 2018
@andresilva andresilva changed the title ethcore: postpone Kovan hard fork Postpone Kovan hard fork Mar 16, 2018
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 16, 2018
@tomusdrw
Copy link
Collaborator

Can we also update fork number in util/version/Cargo.toml and mark the release as critical?

@@ -13,13 +13,13 @@ build = "build.rs"
track = "nightly"

# Indicates a critical release in this track (i.e. consensus issue)
critical = false
critical = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we switch this back to false afterwards?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit unclear for me as well :)
I suppose we should flip it back when bumping new version, but clients updating from say 1.x.N to 1.x.(N+2) should still consider that critical, even though N+2 is not. I don't think that logic is implemented in the updater currently, but don't consider that a blocker.

@tomusdrw tomusdrw merged commit a7887fa into master Mar 19, 2018
@tomusdrw tomusdrw deleted the andre-postpone-kovan-hf branch March 19, 2018 10:23
@andresilva andresilva mentioned this pull request Mar 19, 2018
14 tasks
tomusdrw pushed a commit that referenced this pull request Mar 19, 2018
* ethcore: postpone Kovan hard fork

* util: update version fork metadata
andresilva added a commit that referenced this pull request Mar 19, 2018
* ethcore: postpone Kovan hard fork

* util: update version fork metadata
General-Beck added a commit that referenced this pull request Mar 19, 2018
andresilva added a commit that referenced this pull request Mar 19, 2018
* ethcore: postpone Kovan hard fork

* util: update version fork metadata
andresilva pushed a commit that referenced this pull request Mar 19, 2018
* Postpone Kovan hard fork (#8137)

* ethcore: postpone Kovan hard fork

* util: update version fork metadata

* WASM libraries bump (#7970)

* update wasmi, parity-wasm, wasm-utils to latest version

* Update to new wasmi & error handling

* also utilize new stack limiter

* fix typo

* replace dependency url

* Cargo.lock update
tomusdrw pushed a commit that referenced this pull request Mar 19, 2018
* Support parity protocol. (#8035)

* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* WASM libraries bump (#7970)

* update wasmi, parity-wasm, wasm-utils to latest version

* Update to new wasmi & error handling

* also utilize new stack limiter

* fix typo

* replace dependency url

* Cargo.lock update

* add some dos protection (#8084)

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* fix trace filter returning returning unrelated reward calls, closes #8070 (#8098)

* network: init discovery using healthy nodes (#8061)

* network: init discovery using healthy nodes

* network: fix style grumble

* network: fix typo

* Postpone Kovan hard fork (#8137)

* ethcore: postpone Kovan hard fork

* util: update version fork metadata

* Disable UI by default. (#8105)

* dapps: update parity-ui dependencies (#8160)
@5chdn 5chdn added this to the 1.11 milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants