Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

revert removing blooms #8066

Merged
merged 6 commits into from
Mar 12, 2018
Merged

revert removing blooms #8066

merged 6 commits into from
Mar 12, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 6, 2018

@andresilva @jacogr @amaurymartiny this pr reverts most of bloom changes. Blooms should be as fast as they used to be. I suggest merging this pr and fixing / profiling the underlaying issues after

changes:

revert #7934
revert #7979
revert adding migration v13 (bloom migration), from #7974

apply 6aaf90e
apply 8b43f61

@debris debris added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Mar 6, 2018
@amaury1093
Copy link
Contributor

amaury1093 commented Mar 7, 2018

Just compiled this, I confirm it's working.

Here's my test:

  1. Run parity, open UI.
  2. Refresh UI. On latest master the UI requests hang, on this branch only for ~2s.
  3. Ctrl+C the node. On latest master I get longer than expected, on this branch everything's good.

@andresilva
Copy link
Contributor

Need to revert CURRENT_VERSION to 12 in migration.rs.

Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge this and we should create an issue for the remaining issues:

  • Edge-cases with chain re-ordering;
  • Similar fix for traces;
  • Think about creating a migration, or a utility command, for re-creating the blooms (possibly increasing their width).

@andresilva
Copy link
Contributor

Also anyone who has been running master will probably have to do a db kill due to the DB version downgrade right?

@andresilva andresilva added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 12, 2018
@andresilva andresilva merged commit 66f3c50 into master Mar 12, 2018
@debris debris deleted the revert_blooms branch March 12, 2018 22:43
@tomusdrw tomusdrw mentioned this pull request Mar 16, 2018
9 tasks
andresilva pushed a commit that referenced this pull request Mar 16, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
tomusdrw pushed a commit that referenced this pull request Mar 16, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
@andresilva andresilva mentioned this pull request Mar 16, 2018
14 tasks
debris pushed a commit that referenced this pull request Mar 19, 2018
* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* add some dos protection (#8084)

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* Fix compilation.

* Check one step deeper if we're on release track branches

* add missing pr

* Fix blooms?

* Fix tests compiilation.

* Fix size.
andresilva pushed a commit that referenced this pull request Mar 19, 2018
* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs
tomusdrw pushed a commit that referenced this pull request Mar 19, 2018
* Support parity protocol. (#8035)

* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* WASM libraries bump (#7970)

* update wasmi, parity-wasm, wasm-utils to latest version

* Update to new wasmi & error handling

* also utilize new stack limiter

* fix typo

* replace dependency url

* Cargo.lock update

* add some dos protection (#8084)

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* fix trace filter returning returning unrelated reward calls, closes #8070 (#8098)

* network: init discovery using healthy nodes (#8061)

* network: init discovery using healthy nodes

* network: fix style grumble

* network: fix typo

* Postpone Kovan hard fork (#8137)

* ethcore: postpone Kovan hard fork

* util: update version fork metadata

* Disable UI by default. (#8105)

* dapps: update parity-ui dependencies (#8160)
@5chdn 5chdn added this to the 1.11 milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants