-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute tax-scale bracket index and marginal rate #920
Conversation
Thanks @benjello ! For this particular pull request, tests aren't enough for me to grasp the intent and the behaviours introduced by it. Specifically, it'd be great to:
That'll help me a lot to review your contribution! :) |
f513906
to
ea45201
Compare
ea45201
to
821c6c5
Compare
Rebase + fixup |
e1632ef
to
89c0d85
Compare
be38552
to
f811f4b
Compare
Hey @benjello I profited to add some documentation and typing to better understand the behaviours of these classes, before doing a review of the proposed contribution. |
6b62771
to
0fbc471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @benjello, I added some tests with my guesses and there are still two that fail (see in the comments).
Could you take a look?
5e8c580
to
20bf838
Compare
20bf838
to
1d4a413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
New features
Introduce
AbstractTaxScale.bracket_indices
Allows for computing the bracket index relevant for any taxable base vector
Introduce
MarginalTaxScale.marginal_rates
Allows for computing the marginal rate relevant for any taxable base vector
see also openfisca/openfisca-france#1386