fix: 3622 - no autofocus and clean FocusNode management #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad46236.
# Conflicts: # packages/smooth_app/pubspec.lock # packages/smooth_app/pubspec.yaml
Impacted files: * `edit_new_packagings_component.dart`: applied best practices for `FocusNode` (had to switch to `StatefulWidget` for that) * `Podfile.lock`: wtf * `simple_input_number_field.dart`: removed `autofocus: true` * `simple_input_text_field.dart`: removed `autofocus: true` * `simple_input_widget.dart`: applied best practices for `FocusNode`
monsieurtanuki
requested review from
AshAman999,
M123-dev and
stephanegigandet
Codecov Report
@@ Coverage Diff @@
## develop #3716 +/- ##
===========================================
- Coverage 10.41% 10.40% -0.02%
===========================================
Files 273 273
Lines 13795 13815 +20
===========================================
Hits 1437 1437
- Misses 12358 12378 +20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Can't say if it will work but looks okay code wise, thanks @monsieurtanuki
|
Thank you @M123-dev for the review! |
|
@monsieurtanuki I just got back from a few days off, thank you so much for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
edit_new_packagings_component.dart: applied best practices forFocusNode(had to switch toStatefulWidgetfor that)Podfile.lock: wtfsimple_input_number_field.dart: removedautofocus: truesimple_input_text_field.dart: removedautofocus: truesimple_input_widget.dart: applied best practices forFocusNodeWhat
autofocus: trueparameter for each text field made no sense and probably provoked the referenced issue.autofocus: falsefixed the issue.FocusNode.Fixes bug(s)