Skip to content

Commit

Permalink
Add tooltip to help icon (#3626) (#3870)
Browse files Browse the repository at this point in the history
* Add tooltip to help icon
* Add tooltip to menu icon

Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
Co-authored-by: sayuree <52072402+sayuree@users.noreply.github.com>
  • Loading branch information
abbyhu2000 and sayuree authored Apr 18, 2023
1 parent eb0a315 commit 6d70817
Show file tree
Hide file tree
Showing 5 changed files with 102 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [VisBuilder] Rename "Histogram" to "Bar" in visualization type picker ([2401](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2401))
- [Table Visualization] Fix an issue preventing sorting the first column ([#2828](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2828))
- Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842))
- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573))

### 🚞 Infrastructure

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion src/core/public/chrome/ui/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,13 @@ export function Header({
aria-controls={navId}
ref={toggleCollapsibleNavRef}
>
<EuiIcon type="menu" size="m" />
<EuiIcon
type="menu"
size="m"
title={i18n.translate('core.ui.primaryNav.menu', {
defaultMessage: 'Menu',
})}
/>
</EuiHeaderSectionItemButton>
</EuiHeaderSectionItem>

Expand Down
8 changes: 8 additions & 0 deletions src/core/public/chrome/ui/header/header_help_menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,14 @@ class HeaderHelpMenuUI extends Component<Props, State> {
onClick={this.onMenuButtonClick}
>
<EuiIcon type="questionInCircle" size="m" />
<EuiIcon
type="help"
size="m"
title={intl.formatMessage({
id: 'core.ui.chrome.headerGlobalNav.helpMenuButtonTitle',
defaultMessage: 'Help',
})}
/>
</EuiHeaderSectionItemButton>
);

Expand Down

0 comments on commit 6d70817

Please sign in to comment.