Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Add tooltip to help icon (#3626) #3870

Merged

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Apr 17, 2023

* Add tooltip to help icon

Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>

Add tooltip to menu icon

Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 17, 2023
@abbyhu2000 abbyhu2000 marked this pull request as ready for review April 17, 2023 23:40
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner April 17, 2023 23:40
@joshuarrrr joshuarrrr added autocut Skip the changelog verification check on backports and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Apr 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3870 (1b14678) into 2.x (15361cf) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3870      +/-   ##
==========================================
- Coverage   66.45%   66.39%   -0.06%     
==========================================
  Files        3208     3208              
  Lines       61721    61721              
  Branches     9535     9535              
==========================================
- Hits        41015    40979      -36     
- Misses      18418    18448      +30     
- Partials     2288     2294       +6     
Flag Coverage Δ
Linux 66.39% <ø> (-0.01%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/public/chrome/ui/header/header.tsx 73.33% <ø> (ø)
.../core/public/chrome/ui/header/header_help_menu.tsx 35.55% <ø> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr
Copy link
Member

Manually set DCO to pass because 1b14678 is signed off correctly.

@joshuarrrr joshuarrrr merged commit 6d70817 into opensearch-project:2.x Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants