Add tooltip to help icon #3626

sayuree · 2023-03-17T10:45:17Z

Description

Added tooltip to a Help icon

Issues Resolved

Check List

ashwin-pc · 2023-03-17T20:45:51Z

src/core/public/chrome/ui/header/header_help_menu.tsx

@@ -328,7 +328,7 @@ class HeaderHelpMenuUI extends Component<Props, State> {
        })}
        onClick={this.onMenuButtonClick}
      >
-        <EuiIcon type="help" size="m" />
+        <EuiIcon type="help" size="m" title="Help" />


Suggested change

<EuiIcon type="help" size="m" title="Help" />

<EuiIcon type="help" size="m" title={intl.formatMessage({

id: 'core.ui.chrome.headerGlobalNav.helpMenuButtonTitle',

defaultMessage: 'Help menu',

})} />

KrooshalUX

Please see comment in main issue: #3573 (comment)

abbyhu2000 · 2023-03-22T23:14:38Z

Hi @sayuree, will you be able to make the suggested changes for this PR?

sayuree · 2023-03-23T05:58:18Z

@abbyhu2000 yes, I am able to finish it.

joshuarrrr · 2023-03-23T18:53:37Z

src/core/public/chrome/ui/header/header_help_menu.tsx

+          size="m"
+          title={intl.formatMessage({
+            id: 'core.ui.chrome.headerGlobalNav.helpMenuButtonTitle',
+            defaultMessage: 'Help menu',


Suggested change

defaultMessage: 'Help menu',

defaultMessage: 'Help',

I think the agreed upon text is simply "Help" - @KrooshalUX can you confirm?

It should be Help, yes.

joshuarrrr · 2023-03-23T18:55:48Z

@sayuree This looks great! Can you also add an update to the CHANGELOG.md file? This can go under bug fixes category.

abbyhu2000 · 2023-03-24T19:52:52Z

src/core/public/chrome/ui/header/header.tsx

+                  <EuiIcon
+                    type="menu"
+                    size="m"
+                    title={i18n.translate('core.ui.primaryNav.toggleNavAriaLabel', {


Suggested change

title={i18n.translate('core.ui.primaryNav.toggleNavAriaLabel', {

title={i18n.translate('core.ui.primaryNav.menu', {

I don't think this should be core.ui.primaryNav.toggleNavAriaLabel

abbyhu2000 · 2023-03-24T20:20:59Z

@sayuree Can you also add UI screenshots to show the tooltips on both the help icon and menu icon? Thank you!

sayuree · 2023-03-28T09:33:33Z

@sayuree Can you also add UI screenshots to show the tooltips on both the help icon and menu icon? Thank you!

@abbyhu2000 Here are the screenshots:

joshuarrrr · 2023-03-28T15:40:24Z

@KrooshalUX Screenshots provided.

KrooshalUX

LGTM

abbyhu2000 · 2023-03-29T18:10:52Z

LGTM, will approve after the tests finish running

joshuarrrr · 2023-03-29T23:44:49Z

@sayuree There are some snapshot tests that need to be updated: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/4532314219/jobs/8036242750?pr=3626

You can update snapshots via yarn run test:jest -u

Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Add tooltip to menu icon Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Edit tooltip text Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Add updates to CHANGELOG Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Edit title Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Update snapshots Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>

Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>

sayuree · 2023-04-16T08:17:17Z

@joshuarrrr @abbyhu2000 I have rebased the PR, removed unnecessarily updated snapshots. Tests should approve now.

ananzh

LGTM

opensearch-trigger-bot · 2023-04-17T23:14:29Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3626-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8b0587e7aa683ebe9a25c4a454ddb117c68d7335
# Push it to GitHub
git push --set-upstream origin backport/backport-3626-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-3626-to-1.x.

opensearch-trigger-bot · 2023-04-17T23:14:31Z

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3626-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8b0587e7aa683ebe9a25c4a454ddb117c68d7335
# Push it to GitHub
git push --set-upstream origin backport/backport-3626-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-3626-to-1.3.

opensearch-trigger-bot · 2023-04-17T23:14:32Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3626-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8b0587e7aa683ebe9a25c4a454ddb117c68d7335
# Push it to GitHub
git push --set-upstream origin backport/backport-3626-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3626-to-2.x.

* Add tooltip to help icon Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Add tooltip to menu icon Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>

* Add tooltip to help icon * Add tooltip to menu icon Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Co-authored-by: sayuree <52072402+sayuree@users.noreply.github.com>

* Add tooltip to help icon Add tooltip to menu icon Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Co-authored-by: sayuree <52072402+sayuree@users.noreply.github.com>

sayuree requested a review from a team as a code owner March 17, 2023 10:45

ashwin-pc added the OSCI Open Source Contributor Initiative label Mar 17, 2023

ashwin-pc reviewed Mar 17, 2023

View reviewed changes

KrooshalUX self-requested a review March 17, 2023 21:14

KrooshalUX suggested changes Mar 17, 2023

View reviewed changes

abbyhu2000 self-assigned this Mar 22, 2023

sayuree requested review from KrooshalUX and ashwin-pc and removed request for KrooshalUX March 23, 2023 06:06

joshuarrrr added v2.7.0 backport 1.x backport 2.x v1.3.10 labels Mar 23, 2023

joshuarrrr reviewed Mar 23, 2023

View reviewed changes

joshuarrrr mentioned this pull request Mar 23, 2023

2.7.0 Platform Upgrades for Plugins (O11y, MDS, Geospatial,+) #3674

Closed

23 tasks

sayuree requested review from joshuarrrr and removed request for ashwin-pc March 24, 2023 18:12

abbyhu2000 requested changes Mar 24, 2023

View reviewed changes

sayuree requested review from abbyhu2000 and removed request for joshuarrrr March 28, 2023 09:34

KrooshalUX previously approved these changes Mar 28, 2023

View reviewed changes

sayuree dismissed KrooshalUX’s stale review via 937f297 March 31, 2023 08:13

sayuree requested review from zengyan-amazon, kristenTian, zhongnansu and manasvinibs as code owners April 15, 2023 14:21

sayuree force-pushed the fix-3573 branch from cb1828a to 937f297 Compare April 15, 2023 16:29

sayuree added 2 commits April 15, 2023 23:35

Add upated snapshots

7232753

Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>

sayuree force-pushed the fix-3573 branch from 937f297 to 7232753 Compare April 16, 2023 08:15

abbyhu2000 approved these changes Apr 17, 2023

View reviewed changes

abbyhu2000 added v2.7.0 and removed v2.8.0 labels Apr 17, 2023

ananzh approved these changes Apr 17, 2023

View reviewed changes

abbyhu2000 merged commit 8b0587e into opensearch-project:main Apr 17, 2023

joshuarrrr added the failed backport label Apr 17, 2023

abbyhu2000 mentioned this pull request Apr 17, 2023

[Manual Backport 1.x] Add tooltip to help icon #3871

Merged

abbyhu2000 mentioned this pull request Apr 17, 2023

[Manual Backport 1.3] Add tooltip to help icon (#3626) #3872

Merged

This was referenced Apr 20, 2023

[Manual Backport 2.x] Add tooltip to help icon (#3626) #3870

Merged

[BUG] Duplicate help icons in main nav #3909

Closed

joshuarrrr removed the failed backport label Aug 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tooltip to help icon #3626

Add tooltip to help icon #3626

sayuree commented Mar 17, 2023 •

edited

Loading

ashwin-pc Mar 17, 2023

KrooshalUX left a comment

abbyhu2000 commented Mar 22, 2023

sayuree commented Mar 23, 2023

joshuarrrr Mar 23, 2023

KrooshalUX Mar 24, 2023

joshuarrrr commented Mar 23, 2023

abbyhu2000 Mar 24, 2023

abbyhu2000 Mar 24, 2023

abbyhu2000 commented Mar 24, 2023 •

edited

Loading

sayuree commented Mar 28, 2023 •

edited

Loading

joshuarrrr commented Mar 28, 2023

KrooshalUX left a comment

abbyhu2000 commented Mar 29, 2023

joshuarrrr commented Mar 29, 2023

sayuree commented Apr 16, 2023

ananzh left a comment

opensearch-trigger-bot bot commented Apr 17, 2023

opensearch-trigger-bot bot commented Apr 17, 2023

opensearch-trigger-bot bot commented Apr 17, 2023

	title={i18n.translate('core.ui.primaryNav.toggleNavAriaLabel', {
	title={i18n.translate('core.ui.primaryNav.menu', {

Add tooltip to help icon #3626

Add tooltip to help icon #3626

Conversation

sayuree commented Mar 17, 2023 • edited Loading

Description

Issues Resolved

Check List

ashwin-pc Mar 17, 2023

Choose a reason for hiding this comment

KrooshalUX left a comment

Choose a reason for hiding this comment

abbyhu2000 commented Mar 22, 2023

sayuree commented Mar 23, 2023

joshuarrrr Mar 23, 2023

Choose a reason for hiding this comment

KrooshalUX Mar 24, 2023

Choose a reason for hiding this comment

joshuarrrr commented Mar 23, 2023

abbyhu2000 Mar 24, 2023

Choose a reason for hiding this comment

abbyhu2000 Mar 24, 2023

Choose a reason for hiding this comment

abbyhu2000 commented Mar 24, 2023 • edited Loading

sayuree commented Mar 28, 2023 • edited Loading

joshuarrrr commented Mar 28, 2023

KrooshalUX left a comment

Choose a reason for hiding this comment

abbyhu2000 commented Mar 29, 2023

joshuarrrr commented Mar 29, 2023

sayuree commented Apr 16, 2023

ananzh left a comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Apr 17, 2023

opensearch-trigger-bot bot commented Apr 17, 2023

opensearch-trigger-bot bot commented Apr 17, 2023

sayuree commented Mar 17, 2023 •

edited

Loading

abbyhu2000 commented Mar 24, 2023 •

edited

Loading

sayuree commented Mar 28, 2023 •

edited

Loading