Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: pharmgkb section fix #517

Merged
merged 52 commits into from
Nov 8, 2024
Merged

[Platform]: pharmgkb section fix #517

merged 52 commits into from
Nov 8, 2024

Conversation

chinmehta
Copy link
Contributor

[Platform]: pharmgkb section fix

Description

wrong data accessor resulting in empty in case of receiving the data from api

Issue: (link)
Deploy preview: (link)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

carcruz and others added 30 commits July 22, 2024 22:19
* [Platform] Add Profile and ProfileHeader to variant page (#376)

* [Platform]: variant page widgets init (#380)

* draft pharmacokinetics widget (#383)

* move reported protein link to description (#381)

* [Platform] Add GWAS credible sets widget to variant page (#390)

* [Platform] Add QTL credible sets widget to variant page (#396)

* [Platform] Add Uniprot id to Uniprot description link (#401)

* [Platform] Add allele frequency plot to variant page metadata section (#403)

* frequency vis examples

* polish plots

* allele frequency bars

* use flex for allele frequency plot

* do not import grid

* [Platform] Clean up variant page sections and summaries (#404)

* [Platform] Update variant page QTL credible sets widget (#406)

* [Platform] Use API for variant page header (#412)

* [Platform] Correct dbXref link in variant page header (#414)

* [Platform] Fix clinvar dbXref (#417)

* [Platform] Use API for metadata in variant page (#420)
* [Platform] Add Profile and ProfileHeader to variant page (#376)

* [Platform]: variant page widgets init (#380)

* draft pharmacokinetics widget (#383)

* move reported protein link to description (#381)

* [Platform] Add GWAS credible sets widget to variant page (#390)

* [Platform] Add QTL credible sets widget to variant page (#396)

* [Platform] Add Uniprot id to Uniprot description link (#401)

* [Platform] Add allele frequency plot to variant page metadata section (#403)

* [Platform] Clean up variant page sections and summaries (#404)

* [Platform] Update variant page QTL credible sets widget (#406)

* [Platform] Use API for variant page header (#412)

* [Platform] Correct dbXref link in variant page header (#414)

* [Platform] Fix clinvar dbXref (#417)

* [Platform] Use API for metadata in variant page (#420)

* [Platform] Use API data for in silico predictors widget on variant page (#424)


Co-authored-by: Carlos Cruz <me@carcruzcast.com>

* [Platform] Minor improvements to variant page insilico predictors widget (#429)

* [Platform] Add VEP widget to variant page (#428)
* shorten variant ids in widget descriptions

* avoid DOM nesting warnings
Co-authored-by: Carlos Cruz <me@carcruzcast.com>
* add study table to study page

* fix queries and fill in body

* finish body

* finish draft

* column heading

* link and column updates
* adapt allele frequency plot to order of magnitude

* increase fixed width of right plot column
* add tooltips to posterior probability and r2 columns

* study ID column labels
* include variants in search

* update queries

* comment VariantResults

* include variants in search results page

* add variant details

* update info shown in search suggestions and results

* make rsIds checks boolean

* remove console.log

* use divs to avoid MUI DOM nesting error

* clean up variant search
gjmcn and others added 21 commits October 7, 2024 11:28
* add credible set page

* header and profile

* finish metadata draft

* finish metadata

* consistent case in metadata

* header title and metadata tooltips

* precision

* precsion to 3sf
* sort by exponent then mantissa

* coloc fix
* fix: SharedTraitStudies

* fix: study GWASCredibleSets

* fix: study QTLCredibleSetsSection

---------

Co-authored-by: Carlos Cruz <me@carcruzcast.com>
@chinmehta chinmehta requested review from carcruz and gjmcn November 4, 2024 12:38
@chinmehta chinmehta changed the base branch from main to genetics November 4, 2024 12:43
Base automatically changed from genetics to main November 6, 2024 15:58
@carcruz carcruz merged commit deb0ee5 into main Nov 8, 2024
11 checks passed
@carcruz carcruz deleted the cm-phargkb branch November 8, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants