Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premint: add creator to creator attribution event #163

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Sep 11, 2023

  • Add creator address to creator attribution event.
  • Convert creator attribution fields for name and version from bytes32 to string (to follow the standard)
  • Added test that verifies creator attribution event emitted

This was referenced Sep 11, 2023
@oveddan
Copy link
Collaborator Author

oveddan commented Sep 11, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@oveddan oveddan mentioned this pull request Sep 11, 2023
@oveddan oveddan force-pushed the premint-creator-attribution-add-creator branch from 100222d to c97e5df Compare September 11, 2023 17:28
@oveddan oveddan changed the base branch from premint to main September 11, 2023 17:54
@oveddan oveddan changed the base branch from main to premint September 11, 2023 17:58
@oveddan oveddan force-pushed the premint-creator-attribution-add-creator branch from c97e5df to 20a8648 Compare September 11, 2023 18:19
@oveddan oveddan force-pushed the premint-creator-attribution-add-creator branch from 20a8648 to 9444af7 Compare September 11, 2023 18:45
@oveddan oveddan force-pushed the premint-creator-attribution-add-creator branch from 5e654eb to 6cc5307 Compare September 11, 2023 20:11
@oveddan oveddan marked this pull request as ready for review September 11, 2023 21:03
@oveddan oveddan force-pushed the premint-creator-attribution-add-creator branch from 6cc5307 to 789a5fe Compare September 11, 2023 22:33
…e standard

* Added test that verifies creator attribution event emitted
@kulkarohan
Copy link
Contributor

kulkarohan commented Sep 12, 2023

other than that ^ looks good to merge

@oveddan oveddan merged commit bc7052e into premint Sep 12, 2023
@oveddan oveddan deleted the premint-creator-attribution-add-creator branch September 12, 2023 18:56
oveddan added a commit that referenced this pull request Sep 12, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
oveddan added a commit that referenced this pull request Sep 19, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
oveddan added a commit that referenced this pull request Sep 20, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
oveddan added a commit that referenced this pull request Sep 21, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
oveddan added a commit that referenced this pull request Sep 21, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
oveddan added a commit that referenced this pull request Sep 21, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
This was referenced Sep 21, 2023
iainnash pushed a commit that referenced this pull request Sep 26, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
iainnash pushed a commit that referenced this pull request Sep 27, 2023
* Creator attribution - add creator to event

* * Renamed creator attribution args from bytes32 to string to match the standard
* Added test that verifies creator attribution event emitted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants