Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170

oveddan · 2023-09-14T15:43:36Z

Alternate and cleaner approach to #169

oveddan · 2023-09-14T15:43:53Z

Current dependencies on/for this PR:

main
- PR Fix published package to properly reference types #193
  - PR Prerelease workflow for versioning + publishing prerelease tags #184
    - PR Premint #161
      - PR refactor: only mint if specified quantity is greater than 0 #212
      - PR refactor: implement first minter reward on adminMint #207
        
        PR refactor: remove mint fee amount deploy param #208
      - PR refactor: add helper to read uups implementation #206
      - PR fix: redeem minter tests #203
      - PR move factory to a standalone contract #202
      - PR Move factory upgrade gate to seperate contract #200
      - PR Premint: updated documentation #199
      - PR Add back mint fee getter #198
      - PR Premint - upgradeable premint, new deployment scripts, and premint proxy deployment #189
        
        PR Premint - expose preminter via js sdk #190
        
        PR Premint - factory proxy 777 deployments #191
        
        PR Premint prerelease #187
      - PR Premint - move delegated minter state to its own contract #188
      - PR Prerelease workflow for versioning + publishing prerelease tags #179
        
        PR Premint - proxy deployment and updated deployment scripts #171
        
        PR Update deployment instructions #183
        
        PR Prerelease ci task #178
        
        PR Expose preminter from package #175
        
        PR Premint: pre-release #173
        
        PR Premint: 1.5.0-gasless release #172
      - PR Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170 👈
      - PR Premint - premint executor is upgradeable #168
        
        PR Premint - wrap erc1155 errors in an error that can be decoded - Erc1155CallReverted(bytes errorRevertedData) #169
      - PR Premint - move attribution lib to contract consumed via interface #166
      - PR Premint: fix fork tests #164
      - PR Premint: add creator to creator attribution event #163
      - PR Premint: first minter rewards #162

This comment was auto-generated by Graphite.

oveddan

We can see now the erc1155 errors in the preminter abi:

…mint contract

oveddan · 2023-09-15T02:49:31Z

test/royalties/CreatorRoyaltiesControl.t.sol

@@ -5,7 +5,7 @@ import "forge-std/Test.sol";
 import {ProtocolRewards} from "@zoralabs/protocol-rewards/src/ProtocolRewards.sol";
 import {ZoraCreator1155Impl} from "../../src/nft/ZoraCreator1155Impl.sol";
 import {Zora1155} from "../../src/proxies/Zora1155.sol";
-import {IZoraCreator1155} from "../../src/interfaces/IZoraCreator1155.sol";
+import {IZoraCreator1155Errors} from "../../src/interfaces/IZoraCreator1155Errors.sol";


we actually don't need this import

oveddan · 2023-09-15T02:49:37Z

test/utils/Ownable2StepUpgradable.t.sol

@@ -6,6 +6,7 @@ import {Ownable2StepUpgradeable} from "../../src/utils/ownable/Ownable2StepUpgra
 import {IOwnable2StepUpgradeable} from "../../src/utils/ownable/IOwnable2StepUpgradeable.sol";
 import {ZoraCreator1155FactoryImpl} from "../../src/factory/ZoraCreator1155FactoryImpl.sol";
 import {Zora1155Factory} from "../../src/proxies/Zora1155Factory.sol";
+import {IZoraCreator1155Errors} from "../../src/interfaces/IZoraCreator1155Errors.sol";


we don't need this import

…mint contract (#170)

oveddan mentioned this pull request Sep 14, 2023

Premint - wrap erc1155 errors in an error that can be decoded - Erc1155CallReverted(bytes errorRevertedData) #169

Closed

oveddan commented Sep 14, 2023

View reviewed changes

oveddan force-pushed the premint-upgradeable-premint branch from c122146 to 647fa9b Compare September 14, 2023 16:38

oveddan force-pushed the premint-include-errors-in-abi branch from f145731 to 18a3b68 Compare September 14, 2023 16:38

oveddan force-pushed the premint-upgradeable-premint branch from 647fa9b to 0f3c668 Compare September 14, 2023 16:57

oveddan force-pushed the premint-include-errors-in-abi branch from 18a3b68 to 914fc53 Compare September 14, 2023 16:58

Base automatically changed from premint-upgradeable-premint to premint September 14, 2023 17:09

Extracted erc1155 errors to an interface, and importing that into pre…

865a22c

…mint contract

oveddan force-pushed the premint-include-errors-in-abi branch from 914fc53 to 865a22c Compare September 14, 2023 17:10

oveddan merged commit b197446 into premint Sep 14, 2023

oveddan deleted the premint-include-errors-in-abi branch September 14, 2023 17:13

This was referenced Sep 14, 2023

Premint - proxy deployment and updated deployment scripts #171

Closed

Premint: 1.5.0-gasless release #172

Closed

oveddan commented Sep 15, 2023

View reviewed changes

oveddan added a commit that referenced this pull request Sep 19, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

cf76c18

…mint contract (#170)

oveddan mentioned this pull request Sep 19, 2023

Premint prerelease #187

Closed

oveddan added a commit that referenced this pull request Sep 20, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

be87f52

…mint contract (#170)

oveddan added a commit that referenced this pull request Sep 21, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

090b338

…mint contract (#170)

oveddan added a commit that referenced this pull request Sep 21, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

f2b5de3

…mint contract (#170)

oveddan added a commit that referenced this pull request Sep 21, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

a1265b5

…mint contract (#170)

This was referenced Sep 21, 2023

Add back mint fee getter #198

Merged

Premint: updated documentation #199

Merged

iainnash pushed a commit that referenced this pull request Sep 26, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

55e821e

…mint contract (#170)

This was referenced Sep 26, 2023

Move factory upgrade gate to seperate contract #200

Closed

move factory to a standalone contract #202

Closed

This was referenced Sep 26, 2023

fix: redeem minter tests #203

Merged

refactor: add helper to read uups implementation #206

Merged

refactor: implement first minter reward on adminMint #207

Merged

refactor: remove mint fee amount deploy param #208

Merged

iainnash pushed a commit that referenced this pull request Sep 27, 2023

Extracted erc1155 errors to an interface, and importing that into pre…

d347837

…mint contract (#170)

kulkarohan mentioned this pull request Sep 28, 2023

refactor: only mint if specified quantity is greater than 0 #212

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170

Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170

oveddan commented Sep 14, 2023 •

edited

Loading

oveddan commented Sep 14, 2023 •

edited by kulkarohan

Loading

oveddan left a comment

oveddan Sep 15, 2023

oveddan Sep 15, 2023

Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170

Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170

Conversation

oveddan commented Sep 14, 2023 • edited Loading

oveddan commented Sep 14, 2023 • edited by kulkarohan Loading

oveddan left a comment

Choose a reason for hiding this comment

oveddan Sep 15, 2023

Choose a reason for hiding this comment

oveddan Sep 15, 2023

Choose a reason for hiding this comment

oveddan commented Sep 14, 2023 •

edited

Loading

oveddan commented Sep 14, 2023 •

edited by kulkarohan

Loading