Premint - move attribution lib to contract consumed via interface #166

oveddan · 2023-09-11T22:27:33Z

No description provided.

…#144) * reduce optimizer runs to get contracts to build * Premint V2 - Creator Attribution (#128) * wip on move premint to creator attribution style * updated readme to reflect new contracts * Revert "undo changes to js sdk" This reverts commit 4deabf5. * better comments * Added methods to get status of creator attribution, and validate signatures, useful for the backend * better comments * fixed back fork test * slightly more comments

Created a release

* * Check if key exists reading an address, as to not result in unexpected reverts * In premint tests, allow all forks to run the tests, but skip if there is no address for preminter * update storage layout

It seems that the contract size has increased beyond the limit with this change.

oveddan · 2023-09-11T22:27:48Z

Current dependencies on/for this PR:

main
- PR Fix published package to properly reference types #193
  - PR Prerelease workflow for versioning + publishing prerelease tags #184
    - PR Premint #161
      - PR refactor: only mint if specified quantity is greater than 0 #212
      - PR refactor: implement first minter reward on adminMint #207
        
        PR refactor: remove mint fee amount deploy param #208
      - PR refactor: add helper to read uups implementation #206
      - PR fix: redeem minter tests #203
      - PR move factory to a standalone contract #202
      - PR Move factory upgrade gate to seperate contract #200
      - PR Premint: updated documentation #199
      - PR Add back mint fee getter #198
      - PR Premint - upgradeable premint, new deployment scripts, and premint proxy deployment #189
        
        PR Premint - expose preminter via js sdk #190
        
        PR Premint - factory proxy 777 deployments #191
        
        PR Premint prerelease #187
      - PR Premint - move delegated minter state to its own contract #188
      - PR Prerelease workflow for versioning + publishing prerelease tags #179
        
        PR Premint - proxy deployment and updated deployment scripts #171
        
        PR Update deployment instructions #183
        
        PR Prerelease ci task #178
        
        PR Expose preminter from package #175
        
        PR Premint: pre-release #173
        
        PR Premint: 1.5.0-gasless release #172
      - PR Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170
      - PR Premint - premint executor is upgradeable #168
        
        PR Premint - wrap erc1155 errors in an error that can be decoded - Erc1155CallReverted(bytes errorRevertedData) #169
      - PR Premint - move attribution lib to contract consumed via interface #166 👈
      - PR Premint: fix fork tests #164
      - PR Premint: add creator to creator attribution event #163
      - PR Premint: first minter rewards #162

This comment was auto-generated by Graphite.

oveddan · 2023-09-12T16:48:26Z

Runs into contract size limit...after this change, the size is now:
24.832
Before it was
24.3

Not sure where this is coming from

iainnash · 2023-09-26T20:10:52Z

Did we fix the contract size issue on this? @oveddan

iainnash · 2023-09-26T20:42:29Z

Exploration diff – not meant to be merged.

oveddan and others added 18 commits September 11, 2023 13:07

upgrade viem

ab06344

Gasless

a3a59b8

fix hanging test

534acae

prettier fix

f3b0ad4

Creator attribution deployed contracts

fe84eb7

hack - only test fork on zora goerli for premint

bf9f9b5

deployed new creator attribution

34db100

Created a release

fix: factory tests

2aba02b

chore: remove alt deploy script

2bc790c

refactor: early return token id if token exists

f9f3360

refactor: store 1155 factory as immutable

f9ceeae

chore: update tests

d9a9c49

chore: update tests

8bcabdf

chore: lint

625c958

Premint: fix fork tests (#164)

d54c425

* * Check if key exists reading an address, as to not result in unexpected reverts * In premint tests, allow all forks to run the tests, but skip if there is no address for preminter * update storage layout

wip on moving to an interface

7d6fe39

Updated tests to use new constructor arguments.

1be93bd

It seems that the contract size has increased beyond the limit with this change.

This was referenced Sep 11, 2023

Premint #161

Merged

Premint: first minter rewards #162

Merged

Premint: add creator to creator attribution event #163

Merged

oveddan mentioned this pull request Sep 11, 2023

Premint: fix fork tests #164

Merged

oveddan mentioned this pull request Sep 12, 2023

Premint - premint executor is upgradeable #168

Merged

oveddan force-pushed the premint branch from bc7052e to fbde89a Compare September 12, 2023 22:39

This was referenced Sep 18, 2023

Prerelease ci task #178

Closed

Prerelease workflow for versioning + publishing prerelease tags #179

Merged

Premint prerelease #180

Closed

Update deployment instructions #183

Closed

Prerelease workflow for versioning + publishing prerelease tags #184

Merged

oveddan force-pushed the premint branch from ce6df73 to 8b99658 Compare September 19, 2023 15:12

This was referenced Sep 19, 2023

Premint prerelease #187

Closed

Premint - move delegated minter state to its own contract #188

Merged

oveddan force-pushed the premint branch from 4e23658 to ab48762 Compare September 19, 2023 22:10

This was referenced Sep 19, 2023

Premint - upgradeable premint, new deployment scripts, and premint proxy deployment #189

Merged

Premint - expose preminter via js sdk #190

Merged

Premint - factory proxy 777 deployments #191

Merged

Fix published package to properly reference types #193

Merged

oveddan force-pushed the premint branch 4 times, most recently from 0d1edad to 2c6b7d6 Compare September 21, 2023 20:36

This was referenced Sep 21, 2023

Add back mint fee getter #198

Merged

Premint: updated documentation #199

Merged

iainnash force-pushed the premint branch from 2c6b7d6 to 7b43696 Compare September 26, 2023 19:57

iainnash mentioned this pull request Sep 26, 2023

Move factory upgrade gate to seperate contract #200

Closed

iainnash closed this Sep 26, 2023

iainnash mentioned this pull request Sep 26, 2023

move factory to a standalone contract #202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Premint - move attribution lib to contract consumed via interface #166

Premint - move attribution lib to contract consumed via interface #166

oveddan commented Sep 11, 2023

oveddan commented Sep 11, 2023 •

edited by kulkarohan

Loading

oveddan commented Sep 12, 2023

iainnash commented Sep 26, 2023

iainnash commented Sep 26, 2023

Premint - move attribution lib to contract consumed via interface #166

Premint - move attribution lib to contract consumed via interface #166

Conversation

oveddan commented Sep 11, 2023

oveddan commented Sep 11, 2023 • edited by kulkarohan Loading

oveddan commented Sep 12, 2023

iainnash commented Sep 26, 2023

iainnash commented Sep 26, 2023

oveddan commented Sep 11, 2023 •

edited by kulkarohan

Loading