Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premint - no operator overloading #295

Closed
wants to merge 1 commit into from
Closed

Premint - no operator overloading #295

wants to merge 1 commit into from

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Oct 24, 2023 •
edited
Loading

  • premint v2 - dont overload external operators, have specific names for each function
  • premint validation methods now just take the contract address, allowing them to be used with existing contracts (not requiring contract creation config)
  • extracted premint functionality to lib
  • Defined interface for premint executor

This was referenced Oct 24, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
@oveddan
Copy link
Collaborator Author

oveddan commented Oct 24, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Oct 24, 2023
Merged
Closed
@oveddan oveddan force-pushed the premint-better-mint-arguments branch from dcf6b6a to 0012402 Compare October 24, 2023 18:56
@oveddan oveddan force-pushed the premint-no-operator-overloading branch from a112ddf to 785787f Compare October 24, 2023 18:56
This was referenced Oct 25, 2023
Merged
Merged
@oveddan oveddan force-pushed the premint-better-mint-arguments branch from 0012402 to 1da50ec Compare October 25, 2023 20:43
@oveddan oveddan force-pushed the premint-no-operator-overloading branch from 785787f to 38f04f0 Compare October 25, 2023 20:43
@oveddan oveddan mentioned this pull request Oct 25, 2023
Merged
@oveddan oveddan force-pushed the premint-no-operator-overloading branch from 979b3dc to f449ffc Compare October 26, 2023 18:25
@oveddan oveddan force-pushed the premint-better-mint-arguments branch from 8875fe5 to 6296269 Compare October 30, 2023 22:17
@oveddan oveddan closed this Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 9, 2023
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Nov 17, 2023
Merged
Closed
Merged
@iainnash iainnash deleted the premint-no-operator-overloading branch January 11, 2024 15:37
oveddan added a commit that referenced this pull request Apr 8, 2024
@github-actions @oveddan
Version Packages (#295)
9c55387 
* Version Packages

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan Oved <stangogh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulkarohan kulkarohan kulkarohan left review comments

@IsabellaSmallcombe IsabellaSmallcombe IsabellaSmallcombe approved these changes

@iainnash iainnash iainnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oveddan @iainnash @IsabellaSmallcombe @kulkarohan