Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premint - can execute premint on legacy version of contracts #299

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Premint - can execute premint on legacy version of contracts #299

merged 1 commit into from
Nov 15, 2023
+205 −62

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Oct 25, 2023 •
edited
Loading

If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments. This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function

This was referenced Oct 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
@oveddan
Copy link
Collaborator Author

oveddan commented Oct 25, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@oveddan oveddan force-pushed the rename-royalty-recipient-to-funds-recipient branch from ccd7297 to d1cdc3d Compare October 25, 2023 20:43
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from fa8a0fb to 4d8f817 Compare October 25, 2023 20:43
@oveddan oveddan mentioned this pull request Oct 25, 2023
Merged
@oveddan oveddan force-pushed the rename-royalty-recipient-to-funds-recipient branch from d1cdc3d to 28dafdd Compare October 26, 2023 18:25
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from 4d8f817 to b13aecc Compare October 26, 2023 18:25
@oveddan oveddan force-pushed the rename-royalty-recipient-to-funds-recipient branch from 28dafdd to bf025b1 Compare October 30, 2023 22:52
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from b13aecc to 987a31f Compare October 30, 2023 22:52
This was referenced Oct 30, 2023
Merged
Merged
Merged
Merged
@oveddan oveddan changed the base branch from rename-royalty-recipient-to-funds-recipient to premint_create_referral October 31, 2023 17:41
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from 987a31f to 13bec21 Compare October 31, 2023 17:41
This was referenced Oct 31, 2023
Merged
Merged
Merged
@oveddan oveddan force-pushed the premint_create_referral branch from 1aeeabd to 6e178ec Compare November 14, 2023 20:06
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from 94f103c to fab7fcc Compare November 14, 2023 20:06
@oveddan oveddan mentioned this pull request Nov 14, 2023
Merged
@oveddan oveddan force-pushed the premint_create_referral branch from 6e178ec to a1da19c Compare November 14, 2023 23:24
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from fab7fcc to 58b0ceb Compare November 14, 2023 23:24
@oveddan oveddan force-pushed the premint_create_referral branch from a1da19c to 9d8548b Compare November 15, 2023 00:45
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from 58b0ceb to cbcd00e Compare November 15, 2023 00:45
This was referenced Nov 15, 2023
Merged
Closed
@oveddan oveddan force-pushed the premint_create_referral branch from 9d8548b to 9d2c585 Compare November 15, 2023 01:10
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from cbcd00e to 3a22cd0 Compare November 15, 2023 01:10
@oveddan oveddan force-pushed the premint_create_referral branch from 9d2c585 to 7bf9aac Compare November 15, 2023 01:12
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from 3a22cd0 to e7fcba1 Compare November 15, 2023 01:12
@oveddan oveddan force-pushed the premint_create_referral branch from 7bf9aac to 46afabc Compare November 15, 2023 01:13
@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from e7fcba1 to 4e5a9e9 Compare November 15, 2023 01:13
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 15, 2023 •
edited
Loading

Merge activity

  • Nov 15, 2:48 PM: @oveddan started a stack merge that includes this pull request via Graphite.
  • Nov 15, 2:48 PM: Graphite couldn't merge this pull request because a downstack PR Premint V2 #262 failed to merge.
  • Nov 15, 4:20 PM: @oveddan started a stack merge that includes this pull request via Graphite.
  • Nov 15, 4:20 PM: @oveddan merged this pull request with Graphite.

@oveddan oveddan changed the base branch from premint_create_referral to main November 15, 2023 20:41
@oveddan oveddan dismissed stale reviews from IsabellaSmallcombe, kulkarohan, and iainnash November 15, 2023 20:41

The base branch was changed.

@oveddan oveddan force-pushed the allow-minting-on-v1-contracts branch from 4e5a9e9 to 83ba3eb Compare November 15, 2023 20:41
@oveddan oveddan merged commit 885ffa4 into main Nov 15, 2023
10 checks passed
This was referenced Nov 17, 2023
Merged
Closed
Merged
iainnash pushed a commit that referenced this pull request Jan 5, 2024
@oveddan @kulkarohan
Premint - can execute premint on legacy version of contracts (#299)
ac6b797 
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments.  This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function
iainnash pushed a commit that referenced this pull request Jan 11, 2024
@oveddan
Premint - can execute premint on legacy version of contracts (#299)
1c0caea 
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments.  This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function
iainnash pushed a commit that referenced this pull request Jan 11, 2024
@oveddan @kulkarohan
Premint - can execute premint on legacy version of contracts (#299)
a24f960 
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments.  This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function
@iainnash iainnash deleted the allow-minting-on-v1-contracts branch January 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulkarohan kulkarohan kulkarohan left review comments

@IsabellaSmallcombe IsabellaSmallcombe IsabellaSmallcombe left review comments

@iainnash iainnash iainnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oveddan @iainnash @IsabellaSmallcombe @kulkarohan