Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to unlink contracts before verifying #297

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Oct 25, 2023

Symlink doesnt work with verification with foundry, so this is a hack that allows you to unlink the symlink before deploying, then re-link it after

Copy link
Contributor

@kulkarohan kulkarohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

life saver 🙏

@oveddan
Copy link
Collaborator Author

oveddan commented Oct 25, 2023

Merge activity

  • Oct 25, 4:13 PM: @oveddan started a stack merge that includes this pull request via Graphite.
  • Oct 25, 4:14 PM: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@oveddan oveddan changed the base branch from creator_reward_recipient_per_token_id to main October 25, 2023 20:13
@oveddan oveddan force-pushed the add-unlink-contracts branch from e5f62ec to d6bbf0e Compare October 25, 2023 20:16
@oveddan oveddan merged commit 683d5ef into main Oct 25, 2023
4 checks passed
iainnash pushed a commit that referenced this pull request Jan 11, 2024
Symlink doesnt work with verification with foundry, so this is a hack that allows you to unlink the symlink before deploying, then re-link it after
@iainnash iainnash deleted the add-unlink-contracts branch January 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants