-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add way to unlink contracts before verifying #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 25, 2023
Merged
Merged
kulkarohan
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
life saver 🙏
oveddan
changed the base branch from
creator_reward_recipient_per_token_id
to
main
October 25, 2023 20:13
oveddan
force-pushed
the
add-unlink-contracts
branch
from
October 25, 2023 20:16
e5f62ec
to
d6bbf0e
Compare
This was referenced Oct 25, 2023
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Symlink doesnt work with verification with foundry, so this is a hack that allows you to unlink the symlink before deploying, then re-link it after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlink doesnt work with verification with foundry, so this is a hack that allows you to unlink the symlink before deploying, then re-link it after