New protocol-deployments package - separate versioning of contracts from publishing deployment updates
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Merged
oveddan
changed the base branch from
exit-pre-mode
to
prerelease_premint_api_helper
oveddan
force-pushed
the
separate-deploy-package
branch
from
dd57509 to
3c1992b
Compare
Merged
oveddan
force-pushed
the
separate-deploy-package
branch
from
3c1992b to
4594a5d
Compare
oveddan
force-pushed
the
separate-deploy-package
branch
from
4594a5d to
d85a071
Compare
oveddan
commented
Oct 30, 2023
oveddan
force-pushed
the
separate-deploy-package
branch
from
0de4781 to
c2ce1d2
Compare
This was referenced Oct 31, 2023
Merged
Merged
oveddan
force-pushed
the
separate-deploy-package
branch
from
57134a6 to
ca30120
Compare
oveddan
force-pushed
the
separate-deploy-package
branch
from
ca30120 to
5753fda
Compare
oveddan
changed the title
protocol-deployments package - separate versioning of contracts from publishing package containing addresses where they are deployed
oveddan
changed the title
protocol-deployments package - separate versioning of contracts from publishing package containing addresses where they are deployedprotocol-deployments package - separate versioning of contracts from publishing deployment updates
|
Would be great to create folders to separate the scripts. Given the complexity of the deployment what are your thoughts on creating different packages for each project deployments with a standard pattern? |
This was referenced Nov 1, 2023
yeah maybe imports could be project specific ? eg |
oveddan
force-pushed
the
separate-deploy-package
branch
from
d554799 to
c19731f
Compare
sounds good will do this in a v2 |
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
… from publishing deployment updates (#305) Created new package `protocol-deployments` * deployment scripts for 1155 contracts have been moved from `1155-contracts` to this new package * deployed 1155 contract addresses have been moved from `1155-contracts` to this new package. Problem this solves: * every time we deployed a contract and want to to publish the changes in a package we had to bump the contract version, since we require the package version to match the contract version. With this change, we can version the contracts independently from the deployed addresses. You can see this in action in the upstream branch "Deploy zora sepolia" where we deployed the contracts to the new Zora Sepolia chain, and just bumped the `protocol-deployments` version without needing to bump the `1155-contracts` version. * The `1155-contracts` wagmi generator now just generates abis to bundle in the package json. * The `protocol-deployments` wagmi generator imports the abis from `1155-contracts` and bundles them with the deployed addresses. * `premint-sdk` imports from `protocol-deployments` to get contract abis and addresses from it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new package
protocol-deployments1155-contractsto this new package1155-contractsto this new package.Problem this solves:
With this change, we can version the contracts independently from the deployed addresses.
You can see this in action in the upstream branch "Deploy zora sepolia" where we deployed the contracts to the new Zora Sepolia chain, and just bumped the
protocol-deploymentsversion without needing to bump the1155-contractsversion.1155-contractswagmi generator now just generates abis to bundle in the package json.protocol-deploymentswagmi generator imports the abis from1155-contractsand bundles them with the deployed addresses.premint-sdkimports fromprotocol-deploymentsto get contract abis and addresses from it