Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Complete login #2826

Merged
merged 49 commits into from
Apr 14, 2020
Merged

[New arch] Complete login #2826

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
e7546a3
Create GetUserInfoUseCase
abelgardep Jan 24, 2020
678ab19
Start working on login usecase
abelgardep Feb 3, 2020
880c628
Rename remote operations
abelgardep Feb 7, 2020
73b29c2
WIP AuthenticationActivity Refactorization
abelgardep Feb 12, 2020
79c4a81
Keep working on LoginActivity
abelgardep Feb 14, 2020
72d846b
Update login button status
abelgardep Feb 20, 2020
b7bee86
Replace username and password EditText with TextInputLayout
abelgardep Feb 21, 2020
8e1748e
Complete first basic flow. Pending on account save
abelgardep Feb 24, 2020
7d71346
Fix icons not showing on login landscape mode and theme glitch
abelgardep Feb 25, 2020
55097ab
Handle login screen rotation
abelgardep Feb 25, 2020
da16dd8
Create account handling methods within LocalAuthenticationDataSource …
davigonz Feb 20, 2020
7234ab7
Add account creation methods to OCLocalAuthenticationDataSource
davigonz Feb 26, 2020
1cb6c98
Polish brandable options on LoginActivity
abelgardep Feb 26, 2020
74ec4a1
Provides AuthenticationRepository with enough information to save the…
abelgardep Feb 26, 2020
5143326
Start using new LoginActivity, create account after login
davigonz Feb 26, 2020
a001db5
Multiaccount with new LoginActivity
davigonz Feb 26, 2020
ce3acff
OAuth with new arch, initial commit
davigonz Feb 27, 2020
c6377a9
Create usecase for getting user data and handle authTokenType during …
davigonz Feb 27, 2020
244a7b4
Keep account dependencies in app and data modules
davigonz Feb 28, 2020
a28c791
Complete OAuth login flow
davigonz Feb 28, 2020
f9b4f33
First LoginActivity UI tests
abelgardep Mar 2, 2020
6e1299d
Prepare new LoginActivity to be used where old AuthenticatorActivity …
davigonz Mar 2, 2020
3d129f6
Fix da translation that was triggering a lint failure
davigonz Mar 2, 2020
0a22428
Write base url in LoginActivity when an account needs to be reauthent…
davigonz Mar 3, 2020
f7a9840
Accounts update [WIP]
davigonz Mar 3, 2020
d35a80a
Include ViewModel extension to run different types of usecases and ge…
davigonz Mar 3, 2020
dec5fe3
Test oB options
abelgardep Mar 3, 2020
18e65d7
Do not call viewmodel if url is empty
abelgardep Mar 3, 2020
d9b4b80
Update OAuth and basic accounts; remove old AuthenticatorActivity
davigonz Mar 3, 2020
af31b65
Add tests for OCAuthenticationRepositoryTest, OCLocalAuthentionDataSo…
davigonz Mar 4, 2020
b999423
Remove old operations
abelgardep Mar 4, 2020
01e09af
Complete basic and OAuth account creation and update tests
davigonz Mar 4, 2020
b4860ae
Keep working in loginActivity UI tests
abelgardep Mar 4, 2020
8206a74
Add more tests for authentication usecases
davigonz Mar 5, 2020
0294d62
Move services to library so that library users can use them
davigonz Mar 5, 2020
4ee111d
Fix ui tests
abelgardep Mar 5, 2020
c6bb15c
Continue working on UI tests
abelgardep Mar 6, 2020
65e8cdb
Polish LoginActivityTest
abelgardep Mar 9, 2020
8fe6254
Apply CR changes
davigonz Mar 16, 2020
917d475
Fix Username editable in OAuth2 account edition
davigonz Mar 18, 2020
90bb312
Fix Turning device to landscape, becomes the username field editable
davigonz Mar 18, 2020
0356daf
Fix redirections and a little cleanup
abelgardep Mar 18, 2020
9f917bb
Show specific message when service is unavailable
abelgardep Mar 18, 2020
9015b7f
Assert connectivity before performing a network operation and update …
abelgardep Mar 19, 2020
555b928
Replace old icons with vectorized ones
abelgardep Mar 19, 2020
2c2b816
Add pending test
abelgardep Apr 6, 2020
69af7fc
Fix and add remaining tests
abelgardep Apr 7, 2020
6856d99
Update text when server certificate is not trusted
abelgardep Apr 7, 2020
591d5d1
Update icon and text when server certificate is not trusted
abelgardep Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.3'
classpath 'com.android.tools.build:gradle:3.6.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
classpath "org.jetbrains.kotlin:kotlin-allopen:$kotlinVersion"
}
Expand Down
2 changes: 1 addition & 1 deletion owncloud-android-library
Open in desktop
Submodule owncloud-android-library updated 14 files
+1 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClient.java
+5 −2 owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/accounts/AccountUtils.java
+1 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/files/services/FileService.kt
+34 −0 ...dComLibrary/src/main/java/com/owncloud/android/lib/resources/files/services/implementation/OCFileService.kt
+3 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareService.kt
+1 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareeService.kt
+91 −0 ...omLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareService.kt
+42 −0 ...mLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareeService.kt
+2 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/status/services/CapabilityService.kt
+1 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/status/services/ServerInfoService.kt
+33 −0 ...rary/src/main/java/com/owncloud/android/lib/resources/status/services/implementation/OCCapabilityService.kt
+43 −0 ...rary/src/main/java/com/owncloud/android/lib/resources/status/services/implementation/OCServerInfoService.kt
+2 −1 owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/users/services/UserService.kt
+32 −0 ...dComLibrary/src/main/java/com/owncloud/android/lib/resources/users/services/implementation/OCUserService.kt
5 changes: 5 additions & 0 deletions owncloudApp/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ dependencies {
androidTestImplementation "androidx.test:runner:$androidTestVersion"
androidTestImplementation "androidx.test:runner:$androidTestVersion"
androidTestImplementation "androidx.test.ext:junit:$extJunitVersion"
androidTestImplementation "androidx.test:core-ktx:$androidTestVersion"
androidTestImplementation "androidx.test.espresso:espresso-core:$espressoTestVersion"
androidTestImplementation "androidx.test.espresso:espresso-contrib:$espressoTestVersion"
androidTestImplementation "androidx.test.espresso:espresso-intents:$espressoTestVersion"
Expand Down Expand Up @@ -126,6 +127,10 @@ android {
targetCompatibility JavaVersion.VERSION_1_8
}

kotlinOptions {
jvmTarget = JavaVersion.VERSION_1_8.toString()
}

sourceSets {
androidTest.java.srcDirs += "src/test-common/java"
test.java.srcDirs += "src/test-common/java"
Expand Down
Loading