Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocis reva including config cleanup #556

Merged
merged 7 commits into from
Sep 13, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 12, 2020

No description provided.

@phil-davis phil-davis force-pushed the update-ocis-reva-cleanup-config branch from ca2528c to bc28c51 Compare September 12, 2020 11:52
@phil-davis
Copy link
Contributor

Rebased to run CI against latest master (PR #555 was merged)

I am also working on adding the extra CI to run both owncloud and ocis storage test pipelines.

@phil-davis phil-davis force-pushed the update-ocis-reva-cleanup-config branch from bc28c51 to 389f83d Compare September 12, 2020 12:56
@phil-davis
Copy link
Contributor

I pushed the test and CI-related code changes. These are similar to what was done in owncloud/ocis-reva#466

  • bump the core commit id for tests so that we use the core test code in PR [Tests-Only] Make PROPFIND response href test checks more flexible core#37902 that makes checks of PROPFINF requests of folders more flexible and reliable.
  • change .drone.star so that it runs the local and core API test pipelines for both the "owncloud" and "ocis" storages.
  • skip various local API tests on "ocis" storage. Those tests are to demonstrate existing bugs on "owncloud" storage. The behavior is different on "ocis" storage, and might actually be correct (i.e. bug fixed on "ocis" storage). That needs more detailed investigation.
  • create expected-failures-on-OCIS-storage.txt and adjust it for the core API scenarios that currently fail
  • avoid using skeleton files in the local API tests. It is "more difficult" for the test code to simulate skeleton files in each different storage implementation. The local API tests are not demonstrating skeleton behavior anyway. So they now create users without skeleton and upload the files they need, create the folders they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants