-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂️ eslint core #479
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Reasons for "No need to implement": oxc/tasks/lint_rules/src/oxlint-rules.cjs Lines 44 to 50 in 1282221
|
For new comers:
|
Part of: #479 docs: https://eslint.org/docs/latest/rules/no-new-wrappers I am unsure of what do do with 2 of the eslint tests that use `languageOptions: { globals: { String: "off" } }` and `/* global Boolean:off */`. I've commented them out as of now. --------- Co-authored-by: Boshen <boshenc@gmail.com>
Relates to #479 Rule detail: https://eslint.org/docs/latest/rules/max-lines
Relates to #479 Rule detail: https://eslint.org/docs/latest/rules/no-with
Fixes the unmarked implemented rules in #479.
Implementing rule https://eslint.org/docs/latest/rules/no-undefined This is my first time contributing here, I wanted to started with a simple rule before contributing more. related to #479
Related to #479 --------- Co-authored-by: Don Isaac <donald.isaac@gmail.com>
Contributing to #479 ! Rule Details: [link](https://eslint.org/docs/latest/rules/no-alert) Am new to the internals of parsers and linters so I kept the implementation similar to ESLint's source code Commented out the `globalThis` test cases in the pass array meant for pre-ES2020 before `globalThis` was introduced, having clarified in the Discord that it's ok to treat the built-in `globalThis` as always present. --------- Co-authored-by: Don Isaac <donald.isaac@gmail.com>
This PR adds the `eslint/sort-keys` implementation as part of #479 Note: two tests are commented out. I was not able to model this behavior properly. I would be happy to have some assistance there.
- part of #479 This PR implements the `no-plusplus` rule and is more-or-less a direct port of the ESLint version of the rule. --------- Co-authored-by: Don Isaac <donald.isaac@gmail.com>
- part of #479 This implements the `no-extend-native` rule from the ESLint core ruleset. This was translated based on the rule source code from the ESLint codebase. That means some oddity, such as treating any capitalized identifier (like `Math`) as a global object, is preserved. So even though `Math.prototype` doesn't exist in reality, we still report it as an error. This is probably okay given that such code doesn't make sense anyway.
- part of #479 The bulk of this rule is closely based on the logic from the original ESLint rule. One major difference between this implementation and the original though is the lack of a tokenizer. ESLint uses a proper tokenizer to find identifers, parentheses, brackets, and other tokens. For this rule, I opted to just manually search for the characters we might expect to find. I'm not sure how this will hold up in the real world, I expect it could lead to some missing cases potentially, but it at least works for all of the given test cases.
This PR implements the not-recomennded eslint rule `no-return-assign` #479 --------- Co-authored-by: Cameron <cameron.clark@hey.com>
unicorn/no-nested-ternary has been implemented. Should eslint/no-nested-ternary be marked as complete? Or something else done for this rule? The eslint version doesn't allow any nesting. The unicorn version allows nesting 1 level, as long as it is wrapped in parenthesis. |
In this PR, implement [eslint:yoda](https://eslint.org/docs/latest/rules/yoda) ref: #479
Warning
This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules
This is tracking issue for
eslint
.There are 197(+ 93 deprecated) rules.
To get started, run the following command:
Then register the rule in
crates/oxc_linter/src/rules.rs
and alsodeclare_all_lint_rules
at the bottom.Recommended rules
✨: 57, 🚫: 2 / total: 61
✨ = Implemented, 🚫 = No need to implement
Not recommended rules
✨: 63, 🚫: 1 / total: 136
✨ = Implemented, 🚫 = No need to implement
Deprecated rules
✨: 0, 🚫: 1 / total: 93
✨ = Implemented, 🚫 = No need to implement
The text was updated successfully, but these errors were encountered: