Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(linter/react): use CFG for detecting cyclic subgraphs in rules-of-hooks. #3454

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented May 28, 2024

No description provided.

Copy link

graphite-app bot commented May 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from 14043dd to 658e5d5 Compare May 28, 2024 13:30
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels May 28, 2024
Copy link

codspeed-hq bot commented May 28, 2024

CodSpeed Performance Report

Merging #3454 will not alter performance

Comparing 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ (987a3f3) with main (0007ee4)

Summary

✅ 22 untouched benchmarks

@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from 658e5d5 to ae657bc Compare May 28, 2024 14:48
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from b1e55df to 3012834 Compare May 28, 2024 14:48
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from ae657bc to 857840a Compare May 28, 2024 18:06
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 3012834 to fdc74c2 Compare May 28, 2024 18:07
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from fdc74c2 to a761720 Compare May 30, 2024 17:04
@rzvxa rzvxa changed the base branch from 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s to 05-29-improvement_semantic_cfg_better_break_and_continue_flow May 30, 2024 17:04
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from a761720 to 4b744cb Compare May 30, 2024 17:12
@rzvxa rzvxa changed the base branch from 05-29-improvement_semantic_cfg_better_break_and_continue_flow to 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths May 30, 2024 17:12
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch 2 times, most recently from 393541f to 575a3d3 Compare May 30, 2024 18:11
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 2131366 to ae0f550 Compare May 31, 2024 20:02
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 575a3d3 to 039edb5 Compare May 31, 2024 20:02
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from ae0f550 to 63514b5 Compare May 31, 2024 20:06
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 039edb5 to 2eaa64f Compare May 31, 2024 20:06
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 63514b5 to c3a2747 Compare May 31, 2024 20:18
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 70d5a4e to 5f4dbf4 Compare June 1, 2024 23:15
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 41fe4b3 to c483aff Compare June 1, 2024 23:20
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 5f4dbf4 to 8c5b603 Compare June 1, 2024 23:20
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from c483aff to ef56d3d Compare June 1, 2024 23:32
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 8c5b603 to 1541032 Compare June 1, 2024 23:32
@rzvxa rzvxa marked this pull request as ready for review June 3, 2024 18:37
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from ef56d3d to 35f8b8f Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 1541032 to cade273 Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 35f8b8f to 4edd79d Compare June 5, 2024 19:30
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from cade273 to e1d17b1 Compare June 5, 2024 19:30
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 4edd79d to 21b5bc5 Compare June 6, 2024 06:04
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from e1d17b1 to 8b3f50d Compare June 6, 2024 06:04
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 21b5bc5 to 7d67d9a Compare June 6, 2024 06:13
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 8b3f50d to c958425 Compare June 6, 2024 06:13
@rzvxa rzvxa force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 7d67d9a to 6af736f Compare June 6, 2024 06:16
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from c958425 to 7860e8a Compare June 6, 2024 06:16
Copy link

graphite-app bot commented Jun 6, 2024

Merge activity

@Boshen Boshen force-pushed the 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths branch from 6af736f to 61bae74 Compare June 6, 2024 07:57
@Boshen Boshen force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 7860e8a to 987a3f3 Compare June 6, 2024 07:57
@Boshen Boshen changed the base branch from 05-30-improvement_semantic_cfg_cfg_api_for_detecting_conditional_paths to main June 6, 2024 08:02
@graphite-app graphite-app bot merged commit 987a3f3 into main Jun 6, 2024
22 checks passed
@graphite-app graphite-app bot deleted the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch June 6, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant