improvement(semantic/cfg): better break and continue flow.

[rzvxa]

This PR adds a new edge type called Jump to distinguish between normal edges and jumps.
There is also a control flow context which is used to keep track of cfg scopes and labels. It replaces the old preserve_state and restore_state.
It corrects some mistakes - such as labeled blocks especially labeled continue which wasn't easy to implement with the old approach - in the old control flow but other than that it is mostly refactored to have a more declarative API instead of a procedural approach.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[rzvxa]

• feat(linter/eslint): add no_unreachable rule. #3238 : 2 dependent PRs (#3631 , #3650 )
• feat(semantic/cfg): propagate unreachable edges through subgraphs. #3648
• feat(semantic/cfg): add Condition instruction. #3567
• feat(semantic/cfg): add iteration instructions. #3566
• improvement(semantic/cfg): better control flow for switch statements. #3547
• improvement(semantic/cfg): rework error path. #3519
• improvement(semantic/cfg): better throw control flow. #3473
• improvement(linter/react): use CFG for detecting cyclic subgraphs in rules-of-hooks. #3454
• improvement(semantic/cfg): better CFG API #3472
• improvement(semantic/cfg): better break and continue flow. #3462 👈
• improvement(semantic/cfg): better control flow for ForStatements. #3453
• improvement(semantic/cfg): better control flow for DoWhileStatements. #3452
• improvement(semantic/cfg): better control flow for WhileStatements. #3451
• improvement(semantic/cfg): rework basic blocks. #3381
• fix(linter): memorize visited block id in neighbors_filtered_by_edge_weight #3407
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3462 will not alter performance

_{Comparing 05-29-improvement_semantic_cfg_better_break_and_continue_flow (3c7ee85) with main (0007ee4)}

Summary

✅ 22 untouched benchmarks

[Boshen]

I sometimes don't understand how graphite works, why is conflicting on everything 🤔

[rzvxa]

I sometimes don't understand how graphite works, why is conflicting on everything 🤔

I don't know why it was conflicting either, I've restacked it and it went without any conflicts. It might be the rerere that took care of that, I'm not sure.

[rzvxa]

Nope, seems like there is still something wrong, I'll fix it and let you know.

[rzvxa]

@Boshen OK, I can confirm it was the rerere that resolved the conflict, and the error mentioned in the previous comment was just my old mistake getting auto-repeated. Now it should be good to go.

[graphite-app]

Merge activity

• Jun 6, 3:53 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Jun 6, 4:00 AM EDT: Boshen merged this pull request with the Graphite merge queue.