Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(ast): generate the visit.rs file. #4001

Merged

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 1, 2024

Performance degression is expected since now we are doing more work by visiting things that we wouldn't enter before.

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa requested a review from Boshen July 1, 2024 14:54
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #4001 will degrade performances by 3.51%

Comparing 07-01-improvement_ast_generate_the_visit.rs_file (7a3cb83) with main (4a0eaa0)

Summary

❌ 1 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 07-01-improvement_ast_generate_the_visit.rs_file Change
linter[cal.com.tsx] 718.2 ms 744.4 ms -3.51%

@Boshen Boshen force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from 083d437 to 826b3a4 Compare July 1, 2024 16:16
@Boshen Boshen force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from bf3e9b0 to f0a3024 Compare July 1, 2024 16:17
@rzvxa rzvxa marked this pull request as draft July 1, 2024 16:23
@rzvxa rzvxa force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from 826b3a4 to 684107f Compare July 1, 2024 16:43
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch 2 times, most recently from 4b02efe to 1bb0660 Compare July 1, 2024 16:52
@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 16:58
@rzvxa rzvxa force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from 684107f to e48dcda Compare July 2, 2024 08:56
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from 1bb0660 to b117dc7 Compare July 2, 2024 08:56
@rzvxa rzvxa force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from e48dcda to 6945378 Compare July 2, 2024 09:00
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from b117dc7 to 20e0285 Compare July 2, 2024 09:00
@rzvxa rzvxa force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from 6945378 to e621e99 Compare July 2, 2024 09:03
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from 20e0285 to 0322d69 Compare July 2, 2024 09:03
@rzvxa rzvxa force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from e621e99 to c9cbb2f Compare July 2, 2024 09:52
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from 0322d69 to 0f603eb Compare July 2, 2024 09:52
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 2, 2024 — with Graphite App
@rzvxa rzvxa force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from c9cbb2f to 2b20de5 Compare July 2, 2024 10:06
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from 0f603eb to 803d8a7 Compare July 2, 2024 10:07
Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

Performance degression is expected since now we are doing more work by visiting things that we wouldn't enter before.
@Boshen Boshen force-pushed the 06-28-feat_ast_codegen_generate_visit.rs_ branch from 2b20de5 to 7538af1 Compare July 2, 2024 10:19
@Boshen Boshen force-pushed the 07-01-improvement_ast_generate_the_visit.rs_file branch from 803d8a7 to 7a3cb83 Compare July 2, 2024 10:19
@Boshen Boshen changed the base branch from 06-28-feat_ast_codegen_generate_visit.rs_ to main July 2, 2024 10:36
@graphite-app graphite-app bot merged commit 7a3cb83 into main Jul 2, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-01-improvement_ast_generate_the_visit.rs_file branch July 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants