Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(ast_codegen): use visit_as attribute to create aliased AstKinds. #4011

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 1, 2024

No description provided.

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 21:13
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #4011 will not alter performance

Comparing 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s (71e9286) with 07-01-pref_ast_improve_the_performance_of_visitors (352c0b4)

Summary

✅ 28 untouched benchmarks

@rzvxa rzvxa force-pushed the 07-01-pref_ast_improve_the_performance_of_visitors branch from 650823a to 539783a Compare July 2, 2024 08:56
@rzvxa rzvxa force-pushed the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch from 147d1ad to 173d474 Compare July 2, 2024 08:56
@rzvxa rzvxa force-pushed the 07-01-pref_ast_improve_the_performance_of_visitors branch from 539783a to 9fcc980 Compare July 2, 2024 09:01
@rzvxa rzvxa force-pushed the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch from 173d474 to f9311a1 Compare July 2, 2024 09:01
@rzvxa rzvxa force-pushed the 07-01-pref_ast_improve_the_performance_of_visitors branch from 9fcc980 to 2fbe2bd Compare July 2, 2024 09:04
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-isolated-declarations Isolated Declarations labels Jul 2, 2024
@rzvxa rzvxa force-pushed the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch from f9311a1 to 271482d Compare July 2, 2024 09:04
@rzvxa rzvxa force-pushed the 07-01-pref_ast_improve_the_performance_of_visitors branch from 2fbe2bd to 0b0802d Compare July 2, 2024 09:53
@rzvxa rzvxa force-pushed the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch from 271482d to f744cef Compare July 2, 2024 09:53
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 2, 2024 — with Graphite App
@rzvxa rzvxa force-pushed the 07-01-pref_ast_improve_the_performance_of_visitors branch from 0b0802d to 3d71263 Compare July 2, 2024 10:09
@rzvxa rzvxa force-pushed the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch from f744cef to 1f0d889 Compare July 2, 2024 10:10
Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

@Boshen Boshen force-pushed the 07-01-pref_ast_improve_the_performance_of_visitors branch from 3d71263 to 352c0b4 Compare July 2, 2024 10:22
@Boshen Boshen force-pushed the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch from 1f0d889 to 71e9286 Compare July 2, 2024 10:22
@Boshen Boshen changed the base branch from 07-01-pref_ast_improve_the_performance_of_visitors to main July 2, 2024 10:46
@graphite-app graphite-app bot merged commit 71e9286 into main Jul 2, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s branch July 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants