pref(ast): inline visit walks with small bodies.

[rzvxa]

Attempt to improve the performance of visitors, It is mostly for experiments. I'm not sure how much performance is there to gain back.

• inline plural visits (eg: visit_statements)
• inline enums when there are 5 or fewer match cases
• inline structs when there are 5 or less fields
• inline Visit::alloc

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[rzvxa]

• feat(ast_codegen): introduce the #[span] hint. #4012
• improvement(ast_codegen): use visit_as attribute to create aliased AstKinds. #4011
• pref(ast): inline visit walks with small bodies. #4009 👈
• refactor(ast_codegen): no longer outputs discard variable for empty visitors. #4008
• improvement(ast): generate visit_mut.rs. #4007
• feat(ast_codegen): support for generating VisitMut. #4006
• improvement(ast): generate the visit.rs file. #4001
• feat(ast_codegen): add visit generator #3954
• refactor(ast)!: rename visit_enum_memeber to visit_ts_enum_member. #4000
• refactor(ast)!: rename visit_enum to visit_ts_enum_declaration. #3998
• refactor(ast)!: rename visit_arrow_expression to visit_arrow_function_expression. #3995
• refactor(ast): reorder fields to reflect their visit order. #3994
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4009 will improve performances by 4.35%

_{Comparing 07-01-pref_ast_improve_the_performance_of_visitors (352c0b4) with 07-01-refactor_ast_codegen_no_longer_outputs_discard_variable_for_empty_visitors (b51f75b)}

Summary

⚡ 2 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

	Benchmark	07-01-refactor_ast_codegen_no_longer_outputs_discard_variable_for_empty_visitors	07-01-pref_ast_improve_the_performance_of_visitors	Change
⚡	prepass[react.development.js]	229.2 µs	219.6 µs	+4.35%
⚡	prepass[typescript.js]	30.1 ms	29 ms	+3.74%

[graphite-app]

Merge activity

• Jul 2, 6:16 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Jul 2, 6:46 AM EDT: Boshen merged this pull request with the Graphite merge queue.