feat(ast): add #[ast] attribute to non-visited AST types.

[rzvxa]

Mark everything mentioned in #3815 (comment) as AST.

We now error on the occurrence of non-ast items in the source of truth. It doesn't make sure that all fields and variants are #[ast] and therefore repr_stable but there are only a handful of non-AST types used here(mainly Atom and Span). Since we don't have access to the external types we can't make sure of it unless we find a way to const assert it.

The best we can do until then is to check all field/variant types to be either #[ast] or in a white list. I can add this check to the codegen in an upcoming PR.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[rzvxa]

• refactor(ast_codegen): more versatile generation pipeline. #4540
• perf(ast, ast_codegen): optimize AST structs' memory layouts #4404
• refactor(ast_codegen): abstract passes and generators behind Runner trait. #4556
• fix(ast_codegen): create output path if doesn't exist. #4555
• feat(ast_codegen): add normalize_with to create errors from options. #4554
• refactor(ast_codegen): cleanup schema generated by ast_codegen. #4403
• refactor(ast_codegen): cleanup ast_codegen. #4392
• refactor(ast_codegen): use stringify for generators names. #4388
• feat(ast, ast_macros): apply stable repr to all #[ast] enums #4373
• refactor(ast_codegen): better visit marker parsing. #4371
• feat(ast): add #[ast] attribute to non-visited AST types. #4309 👈
• refactor(ast): rename the visited_node marker to ast. #4289
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4309 will not alter performance

_{Comparing 07-17-feat_ast_add_ast_attribute_to_non-visited_ast_types (d345b84) with main (5f1c7ec)}

Summary

✅ 32 untouched benchmarks

[overlookmotel]

For AST transfer, we'll also need to add #[ast] to types in other crates which are part of the AST (e.g. AssignmentOperator in oxc_syntax, Span in oxc_span), and get codegen to read those crates too. But we can do that in a separate PR.

And as you say, we can't put #[repr(C)] on types from external crates e.g. bumpalo::collections::Vec. Further down the line, I think we should introduce our own Vec type (oxc-project/backlog#18) so we can do it at that point. Right now I think we can skip over worrying about it. While Vec's memory layout is not guaranteed because it's not #[repr(C)], in practice it's completely predictable.

[graphite-app]

Merge activity

• Jul 20, 8:21 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 20, 8:21 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Jul 20, 8:25 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.