Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): cleanup schema generated by ast_codegen. #4403

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 22, 2024

No description provided.

Copy link

graphite-app bot commented Jul 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa changed the title chore: cleanup schema refactor(ast_codegen): cleanup schema generated by ast_codegen. Jul 22, 2024
Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #4403 will not alter performance

Comparing 07-22-chore_cleanup_schema (e736a54) with main (452e0ee)

Summary

✅ 32 untouched benchmarks

@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from d6aa1ac to 39e2e38 Compare July 28, 2024 18:01
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from 34cacf6 to 38b4fc8 Compare July 28, 2024 18:02
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from 39e2e38 to dbcda35 Compare July 29, 2024 18:19
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from 38b4fc8 to af18a31 Compare July 29, 2024 18:21
@rzvxa rzvxa marked this pull request as ready for review July 30, 2024 14:37
@rzvxa rzvxa requested a review from overlookmotel July 30, 2024 14:37
@rzvxa
Copy link
Contributor Author

rzvxa commented Jul 30, 2024

You can review and merge this stack up until here.

@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from dbcda35 to 7950bfa Compare July 30, 2024 20:34
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from af18a31 to fbaa37a Compare July 30, 2024 20:34
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from 7950bfa to 3f83a91 Compare July 30, 2024 21:13
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from fbaa37a to b6fca1f Compare July 30, 2024 21:13
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from 3f83a91 to 8fbe205 Compare July 30, 2024 21:47
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from b6fca1f to 3b3ea00 Compare July 30, 2024 21:47
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that "schema" is now a single list of type defs, rather than 1 per file.

@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from 8fbe205 to 5c6a711 Compare August 1, 2024 23:53
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from 3b3ea00 to b17ecd5 Compare August 1, 2024 23:53
Copy link

graphite-app bot commented Aug 2, 2024

Merge activity

@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_cleanup_ast_codegen_ branch from 5c6a711 to 26c6e80 Compare August 2, 2024 00:09
@rzvxa rzvxa force-pushed the 07-22-chore_cleanup_schema branch from b17ecd5 to e736a54 Compare August 2, 2024 00:10
@rzvxa rzvxa changed the base branch from 07-21-refactor_ast_codegen_cleanup_ast_codegen_ to main August 2, 2024 00:15
@graphite-app graphite-app bot merged commit e736a54 into main Aug 2, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 07-22-chore_cleanup_schema branch August 2, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants