feat(ast, ast_macros): apply stable repr to all `#[ast]` enums #4373

rzvxa · 2024-07-20T10:35:27Z

graphite-app · 2024-07-20T10:35:31Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

rzvxa · 2024-07-20T10:35:39Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

codspeed-hq · 2024-07-21T09:02:03Z

CodSpeed Performance Report

Merging #4373 will not alter performance

_{Comparing 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items (eae401c) with main (452e0ee)}

Summary

✅ 32 untouched benchmarks

crates/oxc_ast/src/ast/macros.rs

crates/oxc_ast_macros/src/lib.rs

overlookmotel · 2024-07-22T21:10:46Z

Aside from comments above, this looks good.

But... I suggest we hold off merging until rest of the stack is complete. With just this PR, the types' memory layouts are not optimal, and you can see it a bit on benchmarks. Let's wait until macro+codegen rearranges the fields so they end up in same order as they were before #[repr(C)] was applied.

crates/oxc_ast_macros/src/lib.rs

overlookmotel · 2024-08-01T23:09:58Z

@rzvxa Aside from comments above, and resolving conflicts, I think this PR + 3 more above it in this stack are ready to merge.

graphite-app · 2024-08-02T00:06:16Z

Merge activity

Aug 1, 8:06 PM EDT: rzvxa added this pull request to the Graphite merge queue.
Aug 1, 8:13 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

closes #4296

## [0.23.1] - 2024-08-06 ### Features - fd2d9da ast: Improve `AstKind::debug_name` (#4553) (DonIsaac) - b3b7028 ast: Implement missing Clone, Hash, and Display traits for literals (#4552) (DonIsaac) - 54047e0 ast: `GetSpanMut` trait (#4609) (overlookmotel) - eae401c ast, ast_macros: Apply stable repr to all `#[ast]` enums (#4373) (rzvxa) - 0c52c0d ast_codegen: Add alignment and size data to the schema. (#4615) (rzvxa) - 229a0e9 minifier: Implement dot define for member expressions (#3959) (camc314) - e42ac3a sourcemap: Add `ConcatSourceMapBuilder::from_sourcemaps` (#4639) (overlookmotel) ### Bug Fixes - 4a56954 codegen: Print raw if value is number is Infinity (#4676) (Boshen) - bf48c7f minifier: Fix `keep_var` keeping vars from arrow functions (#4680) (Boshen) - 9be29af minifier: Temporarily fix shadowed `undefined` variable (#4678) (Boshen) - e8b662a minifier: Various fixes to pass minifier conformance (#4667) (Boshen) - a40a217 parser: Parse `assert` keyword in `TSImportAttributes` (#4610) (Boshen) - 03c643a semantic: Incorrect `scope_id` for catch parameter symbols (#4659) (Dunqing) - 6c612d1 semantic/jsdoc: Handle whitespace absence (#4642) (leaysgur) - 0d2c41a semantic/jsdoc: Panic on parsing `type_name_comment`. (#4632) (rzvxa) - 9f8f299 syntax: Prevent creating invalid u32 IDs (#4675) (overlookmotel) - 5327acd transformer/react: The `require` IdentifierReference does not have a `reference_id` (#4658) (Dunqing) - 3987665 transformer/typescript: Incorrect enum-related `symbol_id`/`reference_id` (#4660) (Dunqing) - 4efd54b transformer/typescript: Incorrect `SymbolFlags` for jsx imports (#4549) (Dunqing) ### Performance - 8dd76e4 codegen: Reduce size of `LineOffsetTable` (#4643) (overlookmotel) - b8e6753 codegen: `u32` indexes in `LineOffsetTable` for source maps (#4641) (overlookmotel) - 6ff200d linter: Change react rules and utils to use `Cow` and `CompactStr` instead of `String` (#4603) (DonIsaac) - 0f5e982 minifier: Only visit arrow expression after dropping `console.log` (#4677) (Boshen) - ff43dff sourcemap: Speed up VLQ encoding (#4633) (overlookmotel) - a330773 sourcemap: Reduce string copying in `ConcatSourceMapBuilder` (#4638) (overlookmotel) - 372316b sourcemap: `ConcatSourceMapBuilder` extend `source_contents` in separate loop (#4634) (overlookmotel) - c7f1d48 sourcemap: Keep local copy of previous token in VLQ encode (#4596) (overlookmotel) - 590d795 sourcemap: Shorten main loop encoding VLQ (#4586) (overlookmotel) ### Documentation - c69ada4 ast: Improve AST node documentation (#4051) (Rintaro Itokawa) ### Refactor - ba70001 ast: Put `assert_layouts.rs` behind `debug_assertions` (#4621) (rzvxa) - 3f53b6f ast: Make AST structs `repr(C)`. (#4614) (rzvxa) - 452e0ee ast: Remove defunct `visit_as` + `visit_args` attrs from `#[ast]` macro (#4599) (overlookmotel) - e78cba6 minifier: Ast passes infrastructure (#4625) (Boshen) - d25dea7 parser: Use `ast_builder` in more places. (#4612) (rzvxa) - 09d9822 semantic: Simplify setting scope flags (#4674) (overlookmotel) - 6e453db semantic: Simplify inherit scope flags from parent scope (#4664) (Dunqing)- 9b51e04 Overhaul napi transformer package (#4592) (DonIsaac) ### Testing - 49d5196 ast: Fix `assert_layouts.rs` offset tests on 32bit platforms. (#4620) (rzvxa) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

## [0.24.0] - 2024-08-08 - 75f2207 traverse: [**BREAKING**] Replace `find_scope` with `ancestor_scopes` returning iterator (#4693) (overlookmotel) - 506709f traverse: [**BREAKING**] Replace `find_ancestor` with `ancestors` returning iterator (#4692) (overlookmotel) ### Features - 23b0040 allocator: Introduce `CloneIn` trait. (#4726) (rzvxa) - 51c1ca0 ast: Derive `CloneIn` for AST types, using `generate_derive`. (#4732) (rzvxa) - e12bd1e ast: Allow conversion from TSAccessibility into &'static str (#4711) (DonIsaac) - fd2d9da ast: Improve `AstKind::debug_name` (#4553) (DonIsaac) - b3b7028 ast: Implement missing Clone, Hash, and Display traits for literals (#4552) (DonIsaac) - 54047e0 ast: `GetSpanMut` trait (#4609) (overlookmotel) - eae401c ast, ast_macros: Apply stable repr to all `#[ast]` enums (#4373) (rzvxa) - ec0b4cb ast_codegen: Add `derive_clone_in` generator. (#4731) (rzvxa) - 2e91ad6 ast_codegen: Support for `generate_derive` marker. (#4728) (rzvxa) - 82e2f6b ast_codegen: Process AST-related `syntax` types. (#4694) (rzvxa) - 0c52c0d ast_codegen: Add alignment and size data to the schema. (#4615) (rzvxa) - 07607d3 ast_codegen, span: Process `Span` through ast_codegen (#4703) (overlookmotel) - 125c5fd ast_codegen, span: Process `SourceType` through ast_codegen. (#4696) (rzvxa) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 229a0e9 minifier: Implement dot define for member expressions (#3959) (camc314) - 33f1312 semantic: Impl GetSpan for AstNode (#4717) (DonIsaac) - e42ac3a sourcemap: Add `ConcatSourceMapBuilder::from_sourcemaps` (#4639) (overlookmotel) - 2e63618 span: Implement `CloneIn` for the AST-related items. (#4729) (rzvxa) - 6a36616 syntax: Derive `CloneIn` for the AST-related items. (#4730) (rzvxa) ### Bug Fixes - 4a56954 codegen: Print raw if value is number is Infinity (#4676) (Boshen) - 94d3c31 minifier: Avoid removing function declaration from `KeepVar` (#4722) (Boshen) - bf43148 minifier: Do not `remove_syntax` in dead_code_elimination (Boshen) - bf48c7f minifier: Fix `keep_var` keeping vars from arrow functions (#4680) (Boshen) - 9be29af minifier: Temporarily fix shadowed `undefined` variable (#4678) (Boshen) - e8b662a minifier: Various fixes to pass minifier conformance (#4667) (Boshen) - 01d85de napi/transform: Update napi files (Boshen) - f290191 oxc_ast_macros: Fix `syn` lacking features to build (Boshen) - a40a217 parser: Parse `assert` keyword in `TSImportAttributes` (#4610) (Boshen) - 03c643a semantic: Incorrect `scope_id` for catch parameter symbols (#4659) (Dunqing) - 6c612d1 semantic/jsdoc: Handle whitespace absence (#4642) (leaysgur) - 0d2c41a semantic/jsdoc: Panic on parsing `type_name_comment`. (#4632) (rzvxa) - 9f8f299 syntax: Prevent creating invalid u32 IDs (#4675) (overlookmotel) - 4797eaa transformer: Strip TS statements from for in/of statement bodies (#4686) (overlookmotel) - 5327acd transformer/react: The `require` IdentifierReference does not have a `reference_id` (#4658) (Dunqing) - 3987665 transformer/typescript: Incorrect enum-related `symbol_id`/`reference_id` (#4660) (Dunqing) - 4efd54b transformer/typescript: Incorrect `SymbolFlags` for jsx imports (#4549) (Dunqing) ### Performance - 8dd76e4 codegen: Reduce size of `LineOffsetTable` (#4643) (overlookmotel) - b8e6753 codegen: `u32` indexes in `LineOffsetTable` for source maps (#4641) (overlookmotel) - 6ff200d linter: Change react rules and utils to use `Cow` and `CompactStr` instead of `String` (#4603) (DonIsaac) - 0f5e982 minifier: Only visit arrow expression after dropping `console.log` (#4677) (Boshen) - ff43dff sourcemap: Speed up VLQ encoding (#4633) (overlookmotel) - a330773 sourcemap: Reduce string copying in `ConcatSourceMapBuilder` (#4638) (overlookmotel) - 372316b sourcemap: `ConcatSourceMapBuilder` extend `source_contents` in separate loop (#4634) (overlookmotel) - c7f1d48 sourcemap: Keep local copy of previous token in VLQ encode (#4596) (overlookmotel) - 590d795 sourcemap: Shorten main loop encoding VLQ (#4586) (overlookmotel) ### Documentation - c69ada4 ast: Improve AST node documentation (#4051) (Rintaro Itokawa) ### Refactor - 579b797 ast: Use type identifier instead of `CloneIn::Cloned` GAT. (#4738) (rzvxa) - 475266d ast: Use correct lifetimes for name-related methods (#4712) (DonIsaac) - 83b6ca9 ast: Add explicit enum discriminants. (#4689) (rzvxa) - ba70001 ast: Put `assert_layouts.rs` behind `debug_assertions` (#4621) (rzvxa) - 3f53b6f ast: Make AST structs `repr(C)`. (#4614) (rzvxa) - 452e0ee ast: Remove defunct `visit_as` + `visit_args` attrs from `#[ast]` macro (#4599) (overlookmotel) - 2218340 ast, ast_codegen: Use `generate_derive` for implementing `GetSpan` and `GetSpanMut` traits. (#4735) (rzvxa) - fbfd852 minifier: Add `NodeUtil` trait for accessing symbols on ast nodes (#4734) (Boshen) - e0832f8 minifier: Use `oxc_traverse` for AST passes (#4725) (Boshen) - 17602db minifier: Move tests and files around (Boshen) - 3289477 minifier: Clean up tests (#4724) (Boshen) - e78cba6 minifier: Ast passes infrastructure (#4625) (Boshen) - d25dea7 parser: Use `ast_builder` in more places. (#4612) (rzvxa) - 09d9822 semantic: Simplify setting scope flags (#4674) (overlookmotel) - 6e453db semantic: Simplify inherit scope flags from parent scope (#4664) (Dunqing) - e1429e5 span: Reduce #[cfg_attr] boilerplate in type defs (#4702) (overlookmotel) - e24fb5b syntax: Add explicit enum discriminants to AST related types. (#4691) (rzvxa) - 3f3cb62 syntax, span: Reduce #[cfg_attr] boilerplate in type defs (#4698) (overlookmotel) - 54f9897 traverse: Simpler code for entering/exiting unconditional scopes (#4685) (overlookmotel) - 83546d3 traverse: Enter node before entering scope (#4684) (overlookmotel)- 9b51e04 Overhaul napi transformer package (#4592) (DonIsaac) ### Testing - 49d5196 ast: Fix `assert_layouts.rs` offset tests on 32bit platforms. (#4620) (rzvxa) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

This was referenced Jul 20, 2024

refactor(ast): rename the visited_node marker to ast. #4289

Merged

feat(ast): add #[ast] attribute to non-visited AST types. #4309

Merged

rzvxa mentioned this pull request Jul 20, 2024

refactor(ast_codegen): better visit marker parsing. #4371

Merged

github-actions bot added the A-ast Area - AST label Jul 20, 2024

overlookmotel force-pushed the 07-20-refactor_ast_codegen_better_visit_marker_parsing branch from a9a09d1 to 759180e Compare July 20, 2024 12:06

overlookmotel force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 0387629 to 9367762 Compare July 20, 2024 12:06

overlookmotel force-pushed the 07-20-refactor_ast_codegen_better_visit_marker_parsing branch from 759180e to 5f6d7f1 Compare July 20, 2024 12:25

overlookmotel force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 9367762 to 2d948ed Compare July 20, 2024 12:26

rzvxa force-pushed the 07-20-refactor_ast_codegen_better_visit_marker_parsing branch from 5f6d7f1 to 524c27b Compare July 20, 2024 16:04

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 2d948ed to dd4eaca Compare July 20, 2024 16:04

rzvxa force-pushed the 07-20-refactor_ast_codegen_better_visit_marker_parsing branch from 524c27b to 77a8291 Compare July 20, 2024 16:54

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from dd4eaca to 2bef8e9 Compare July 20, 2024 16:54

overlookmotel force-pushed the 07-20-refactor_ast_codegen_better_visit_marker_parsing branch from 77a8291 to 7a3e925 Compare July 20, 2024 17:07

overlookmotel changed the base branch from 07-20-refactor_ast_codegen_better_visit_marker_parsing to main July 20, 2024 17:10

overlookmotel force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 2bef8e9 to 1d80265 Compare July 20, 2024 17:10

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 1d80265 to faf24ec Compare July 21, 2024 08:55

rzvxa requested a review from overlookmotel July 21, 2024 09:14

rzvxa marked this pull request as ready for review July 21, 2024 09:14

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from faf24ec to 9569b64 Compare July 21, 2024 09:14

rzvxa changed the title ~~feat(ast, ast_macros): apply stable_repr to all #[ast] items.~~ feat(ast, ast_macros): apply stable repr to all #[ast] items. Jul 21, 2024

overlookmotel requested changes Jul 22, 2024

View reviewed changes

crates/oxc_ast/src/ast/macros.rs Outdated Show resolved Hide resolved

crates/oxc_ast/src/ast/macros.rs Outdated Show resolved Hide resolved

crates/oxc_ast_macros/src/lib.rs Show resolved Hide resolved

crates/oxc_ast_macros/src/lib.rs Show resolved Hide resolved

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 6cd87da to e2ccf8e Compare July 28, 2024 18:01

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from e2ccf8e to 33926f6 Compare July 29, 2024 18:18

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch 2 times, most recently from b2fdf20 to c28e09d Compare July 30, 2024 21:47

overlookmotel reviewed Aug 1, 2024

View reviewed changes

crates/oxc_ast_macros/src/lib.rs Outdated Show resolved Hide resolved

crates/oxc_ast_macros/src/lib.rs Outdated Show resolved Hide resolved

crates/oxc_ast_macros/src/lib.rs Show resolved Hide resolved

crates/oxc_ast_macros/src/lib.rs Outdated Show resolved Hide resolved

overlookmotel changed the title ~~feat(ast, ast_macros): apply stable repr to all #[ast] items.~~ feat(ast, ast_macros): apply stable repr to all #[ast] enums Aug 1, 2024

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 1ee05bb to dee3316 Compare August 1, 2024 23:53

rzvxa requested a review from overlookmotel August 1, 2024 23:55

overlookmotel approved these changes Aug 2, 2024

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 2, 2024

feat(ast, ast_macros): apply stable repr to all #[ast] enums (#4373)

eae401c

closes #4296

rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from dee3316 to eae401c Compare August 2, 2024 00:08

graphite-app bot merged commit eae401c into main Aug 2, 2024
26 checks passed

graphite-app bot deleted the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch August 2, 2024 00:13

oxc-bot mentioned this pull request Aug 6, 2024

Release crates v0.23.1 #4681

Merged

oxc-bot mentioned this pull request Aug 8, 2024

Release crates v0.24.0 #4749

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ast, ast_macros): apply stable repr to all `#[ast]` enums #4373

feat(ast, ast_macros): apply stable repr to all `#[ast]` enums #4373

rzvxa commented Jul 20, 2024 •

edited

Loading

graphite-app bot commented Jul 20, 2024

rzvxa commented Jul 20, 2024 •

edited

Loading

codspeed-hq bot commented Jul 21, 2024 •

edited

Loading

overlookmotel commented Jul 22, 2024

overlookmotel commented Aug 1, 2024

graphite-app bot commented Aug 2, 2024 •

edited

Loading

feat(ast, ast_macros): apply stable repr to all #[ast] enums #4373

feat(ast, ast_macros): apply stable repr to all #[ast] enums #4373

Conversation

rzvxa commented Jul 20, 2024 • edited Loading

graphite-app bot commented Jul 20, 2024

Your org has enabled the Graphite merge queue for merging into main

rzvxa commented Jul 20, 2024 • edited Loading

codspeed-hq bot commented Jul 21, 2024 • edited Loading

CodSpeed Performance Report

Merging #4373 will not alter performance

Summary

overlookmotel commented Jul 22, 2024

overlookmotel commented Aug 1, 2024

graphite-app bot commented Aug 2, 2024 • edited Loading

Merge activity

feat(ast, ast_macros): apply stable repr to all `#[ast]` enums #4373

feat(ast, ast_macros): apply stable repr to all `#[ast]` enums #4373

rzvxa commented Jul 20, 2024 •

edited

Loading

rzvxa commented Jul 20, 2024 •

edited

Loading

codspeed-hq bot commented Jul 21, 2024 •

edited

Loading

graphite-app bot commented Aug 2, 2024 •

edited

Loading