feat(linter): implement eslint/no-invalid-regexp
#5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
commented
Sep 4, 2024
CodSpeed Performance ReportMerging #5443 will degrade performances by 37.94%Comparing Summary
Benchmarks breakdown
|
|
OK, I will take this. 🤭 (Prettier... too far to go...) |
|
Basically done. But I'd like to fix diagnostic labels in the parser to align display. => #5543 |
|
Benchmark...why... 😮 |
|
The widest brown:
This rule:
...🤷🏻♂️ |
|
Strange ... I'll take a look. |
|
According to #5570 (comment) , is it because But the commit just before the performance problem was 1e26fce .
And here is a diff of that commit and the latest. Since I only adjusted |
Boshen
force-pushed
the
no-invalid-regexp
branch
2 times, most recently
from
bd91c1a to
7fd4721
Compare
Merge activity
|
|
Codspeed is drunk, I don't see anything wrong. |
Boshen
force-pushed
the
no-invalid-regexp
branch
from
7fd4721 to
24d6a47
Compare
Boshen
added a commit
that referenced
this pull request
Sep 12, 2024
## [0.9.4] - 2024-09-12 ### Features - 9ca2593 linter: Eslint/sort-keys (#4845) (Na'aman Hirschfeld) - 023c160 linter: Impl `Serialize` for `OxlintConfig` (#5594) (DonIsaac) - 24d6a47 linter: Implement `eslint/no-invalid-regexp` (#5443) (Boshen) ### Bug Fixes - af6d240 linter: Panic in consistent-function-scoping (#5613) (DonIsaac) - 54e2e76 linter: `react/no_set_state` + `react/no_string_refs` rules find correct parent (#5615) (overlookmotel) - 3b87ac4 linter: Fix no_unused_vars panic when encountering unicode (#5582) (Boshen) ### Performance - bfe9186 linter: Use `cow_replace` instead of `replace` (#5643) (dalaoshu) - e3ae5db linter: Use cow_to_ascii_lowercase/uppercase (#5637) (heygsc) - a0370bf linter: Use cow_utils in no_script_url (#5633) (heygsc) - 37e922c linter: `eslint/no_shadow_restricted_names` use `run_on_symbol` (#5618) (overlookmotel) - 0b7fccf linter: `react/no_set_state` + `react/no_string_refs` rules reduce iteration over ancestors (#5616) (overlookmotel) - 2c3f3fe linter: Make `jsx_key` slightly faster (#5585) (Boshen) - cd81d12 linter: Add `should_run` to check path only once to nextjs/no_typos (#5584) (Boshen) - d18c896 rust: Use `cow_utils` instead (#5664) (dalaoshu) ### Documentation - 64f9575 linter: Add plugin usage to example with configuration (Boshen) - 8c9179d linter: Fix typos (#5591) (Brian Donovan) ### Refactor - 9e9435f linter: Add `LintFilter` (#5685) (DonIsaac) - 4f70fe5 linter: Start internal/external split of LintPluginOptions (#5660) (DonIsaac) - 5ae9b48 linter: Start internal/external split of `OxlintOptions` (#5659) (DonIsaac) - c8bc6f0 linter: Use `std::ptr::eq` (#5649) (overlookmotel) - a37c064 linter: Use `ContentHash` for `no_duplicate_case`; remove `calculate_hash` (#5648) (Boshen) - 0b3c1d7 linter: Start internal/external split of `OxlintConfig` (#5595) (DonIsaac) - 89bdf55 linter: Inline `Rule` trait default methods (#5619) (overlookmotel) - afea8d5 linter: Rename `Rule` trait method params (#5617) (overlookmotel) - 4e748b5 linter: Replace ast "compare by hash" to "compare by content" (#5602) (dalaoshu) - bac03e3 linter: Make fields of `LintServiceOptions` private (#5593) (DonIsaac) - 2661d8b linter: Jest prefer_strict_equal (#5588) (IWANABETHATGUY) - 20d0068 oxlint: Move cli-related exports to `cli` module (#5139) (DonIsaac) - 067f9b5 semantic: Introduce `IsGlobalReference` trait (#5672) (Boshen)- 26d9235 Enable clippy::ref_as_ptr (#5577) (夕舞八弦) ### Testing - 8e79f8d linter: Add class method test cases for `oxc/no-async-await` (#5550) (DonIsaac) - 3835189 linter: Add test case for no_unused_vars in 3b87ac4 (Boshen) - 5f27551 linter: Add a passing case to no_undef (#5580) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #611
@leaysgur Kicking of
no-invalid-regexp, feel free to take over and claim the bounty on #611 😁I can continue if you wanna work on other stuff (getting confused in prettier land ;-))