Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter): remove redundant clone of diagnostics in context #5797

Conversation

DonIsaac
Copy link
Contributor

No description provided.

Copy link
Contributor Author

DonIsaac commented Sep 15, 2024

Copy link

graphite-app bot commented Sep 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 15, 2024
@DonIsaac DonIsaac added the C-performance Category - Solution not expected to change functional behavior, only performance label Sep 15, 2024
Copy link

codspeed-hq bot commented Sep 15, 2024

CodSpeed Performance Report

Merging #5797 will not alter performance

Comparing don/09-15-perf_linter_redundant_clone_of_diagnostics_in_context (1bfa515) with main (17cd903)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac marked this pull request as ready for review September 16, 2024 02:20
@DonIsaac DonIsaac changed the title perf(linter): redundant clone of diagnostics in context perf(linter): remove redundant clone of diagnostics in context Sep 16, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 16, 2024 — with Graphite App
Copy link

graphite-app bot commented Sep 16, 2024

Merge activity

@Boshen Boshen force-pushed the don/09-15-perf_linter_move_shared_context_info_to_contexthost_ branch from ecaa30e to e413cad Compare September 16, 2024 04:22
@Boshen Boshen force-pushed the don/09-15-perf_linter_redundant_clone_of_diagnostics_in_context branch from 3d9577d to 1bfa515 Compare September 16, 2024 04:22
Base automatically changed from don/09-15-perf_linter_move_shared_context_info_to_contexthost_ to main September 16, 2024 04:35
@graphite-app graphite-app bot merged commit 1bfa515 into main Sep 16, 2024
27 checks passed
@graphite-app graphite-app bot deleted the don/09-15-perf_linter_redundant_clone_of_diagnostics_in_context branch September 16, 2024 04:38
@oxc-bot oxc-bot mentioned this pull request Sep 18, 2024
Boshen added a commit that referenced this pull request Sep 18, 2024
## [0.9.6] - 2024-09-18

### Features

- 3bf7b24 linter: Make `typescript/no-duplicate-enum-values` a
`correctness` rule (#5810) (DonIsaac)
- 7799c06 linter/react: Implement `no-danger-with-children` rule (#5420)
(Cam McHenry)

### Bug Fixes

- f942485 linter: Remove all* remaining "Disallow <foo>" messages
(#5812) (DonIsaac)
- b5ad518 linter: Improve diagnostic messages for various lint rules
(#5808) (DonIsaac)
- 858f7af linter: Plugin prefix name for eslint-plugin-node (#5807)
(DonIsaac)
- 737ba1d linter: Fix some cases on ```AssignmentExpression``` for
```unicorn/consistent-function-scoping``` (#5675) (Arian94)
- 148c7a8 linter: Replace bitwise AND (&) with logical AND (&&) in
explici… (#5780) (kaykdm)
- b4ed564 linter/no-unused-vars: Writes to members triggering false
positive (#5744) (Dunqing)
- e9c084a linter/no-unused-vars: False positive when a variable used as
a computed member property (#5722) (Dunqing)

### Performance

- 3725d5d linter: Make all rules share a diagnostics vec (#5806)
(DonIsaac)
- e978567 linter: Shrink size of `DisableDirectives` (#5798) (DonIsaac)
- 1bfa515 linter: Remove redundant clone of diagnostics in context
(#5797) (DonIsaac)
- e413cad linter: Move shared context info to `ContextHost` (#5795)
(DonIsaac)

### Refactor

- 6dd6f7c ast: Change `Comment` struct (#5783) (Boshen)
- 7caae5b codegen: Add `GetSpan` requirement to `Gen` trait (#5772)
(Boshen)
- 026ee6a linter: Decouple module resolution from import plugin (#5829)
(dalaoshu)
- 50834bc linter: Move `override_rule` to `OxlintRules` (#5708)
(DonIsaac)
- a438743 linter: Move `OxlintConfig` to `Oxlintrc` (#5707) (DonIsaac)
- f61e8b5 linter: Impl serde and schemars traits for `LintPlugins`
(#5706) (DonIsaac)
- 20a7861 linter: Shorten `Option` syntax (#5735) (overlookmotel)
- d8b612c oxc_linter: Prefer pass Enum instead of str `no_plus_plus`
(#5730) (IWANABETHATGUY)
- cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants