Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): move override_rule to OxlintRules #5708

Conversation

DonIsaac
Copy link
Contributor

No description provided.

Copy link
Contributor Author

DonIsaac commented Sep 11, 2024

Copy link

graphite-app bot commented Sep 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #5708 will not alter performance

Comparing don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ (50834bc) with main (b5ac5a6)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_oxlintconfig_to_oxlintrc_ branch from 6af1163 to a215d35 Compare September 12, 2024 13:08
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from d778abb to e34d0b4 Compare September 12, 2024 13:08
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_oxlintconfig_to_oxlintrc_ branch from a215d35 to 3e6e022 Compare September 13, 2024 15:04
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from e34d0b4 to ae7618d Compare September 13, 2024 15:04
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_oxlintconfig_to_oxlintrc_ branch 2 times, most recently from f91de33 to d25b005 Compare September 14, 2024 11:22
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from ae7618d to ffa122d Compare September 14, 2024 11:22
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_oxlintconfig_to_oxlintrc_ branch from d25b005 to a663d20 Compare September 16, 2024 17:36
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from ffa122d to 754f9e0 Compare September 16, 2024 17:37
@DonIsaac DonIsaac marked this pull request as ready for review September 16, 2024 17:38
@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 16, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 17, 2024
Copy link

graphite-app bot commented Sep 17, 2024

Merge activity

  • Sep 17, 1:15 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 17, 1:15 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 17, 1:21 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/09-11-refactor_linter_move_oxlintconfig_to_oxlintrc_ branch from a663d20 to a438743 Compare September 17, 2024 05:15
@Boshen Boshen force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from 754f9e0 to 50834bc Compare September 17, 2024 05:16
Base automatically changed from don/09-11-refactor_linter_move_oxlintconfig_to_oxlintrc_ to main September 17, 2024 05:19
@graphite-app graphite-app bot merged commit 50834bc into main Sep 17, 2024
27 checks passed
@graphite-app graphite-app bot deleted the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch September 17, 2024 05:21
@oxc-bot oxc-bot mentioned this pull request Sep 18, 2024
Boshen added a commit that referenced this pull request Sep 18, 2024
## [0.9.6] - 2024-09-18

### Features

- 3bf7b24 linter: Make `typescript/no-duplicate-enum-values` a
`correctness` rule (#5810) (DonIsaac)
- 7799c06 linter/react: Implement `no-danger-with-children` rule (#5420)
(Cam McHenry)

### Bug Fixes

- f942485 linter: Remove all* remaining "Disallow <foo>" messages
(#5812) (DonIsaac)
- b5ad518 linter: Improve diagnostic messages for various lint rules
(#5808) (DonIsaac)
- 858f7af linter: Plugin prefix name for eslint-plugin-node (#5807)
(DonIsaac)
- 737ba1d linter: Fix some cases on ```AssignmentExpression``` for
```unicorn/consistent-function-scoping``` (#5675) (Arian94)
- 148c7a8 linter: Replace bitwise AND (&) with logical AND (&&) in
explici… (#5780) (kaykdm)
- b4ed564 linter/no-unused-vars: Writes to members triggering false
positive (#5744) (Dunqing)
- e9c084a linter/no-unused-vars: False positive when a variable used as
a computed member property (#5722) (Dunqing)

### Performance

- 3725d5d linter: Make all rules share a diagnostics vec (#5806)
(DonIsaac)
- e978567 linter: Shrink size of `DisableDirectives` (#5798) (DonIsaac)
- 1bfa515 linter: Remove redundant clone of diagnostics in context
(#5797) (DonIsaac)
- e413cad linter: Move shared context info to `ContextHost` (#5795)
(DonIsaac)

### Refactor

- 6dd6f7c ast: Change `Comment` struct (#5783) (Boshen)
- 7caae5b codegen: Add `GetSpan` requirement to `Gen` trait (#5772)
(Boshen)
- 026ee6a linter: Decouple module resolution from import plugin (#5829)
(dalaoshu)
- 50834bc linter: Move `override_rule` to `OxlintRules` (#5708)
(DonIsaac)
- a438743 linter: Move `OxlintConfig` to `Oxlintrc` (#5707) (DonIsaac)
- f61e8b5 linter: Impl serde and schemars traits for `LintPlugins`
(#5706) (DonIsaac)
- 20a7861 linter: Shorten `Option` syntax (#5735) (overlookmotel)
- d8b612c oxc_linter: Prefer pass Enum instead of str `no_plus_plus`
(#5730) (IWANABETHATGUY)
- cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants