Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): impl serde and schemars traits for LintPlugins #5706

Conversation

DonIsaac
Copy link
Contributor

No description provided.

Copy link
Contributor Author

DonIsaac commented Sep 11, 2024

Copy link

graphite-app bot commented Sep 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #5706 will not alter performance

Comparing don/09-11-refactor_linter_impl_serde_and_schemars_traits_for_lintplugins_ (f61e8b5) with main (7caae5b)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_impl_serde_and_schemars_traits_for_lintplugins_ branch from b8bb06e to 0ce0d59 Compare September 12, 2024 13:08
@DonIsaac DonIsaac marked this pull request as ready for review September 13, 2024 15:03
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_impl_serde_and_schemars_traits_for_lintplugins_ branch from 0ce0d59 to 2764701 Compare September 13, 2024 15:04
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Sep 14, 2024
Copy link

graphite-app bot commented Sep 14, 2024

Merge activity

  • Sep 14, 7:15 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 14, 7:15 AM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 14, 7:21 AM EDT: DonIsaac merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_impl_serde_and_schemars_traits_for_lintplugins_ branch from 2764701 to f61e8b5 Compare September 14, 2024 11:16
@graphite-app graphite-app bot merged commit f61e8b5 into main Sep 14, 2024
24 checks passed
@graphite-app graphite-app bot deleted the don/09-11-refactor_linter_impl_serde_and_schemars_traits_for_lintplugins_ branch September 14, 2024 11:21
@oxc-bot oxc-bot mentioned this pull request Sep 18, 2024
Boshen added a commit that referenced this pull request Sep 18, 2024
## [0.9.6] - 2024-09-18

### Features

- 3bf7b24 linter: Make `typescript/no-duplicate-enum-values` a
`correctness` rule (#5810) (DonIsaac)
- 7799c06 linter/react: Implement `no-danger-with-children` rule (#5420)
(Cam McHenry)

### Bug Fixes

- f942485 linter: Remove all* remaining "Disallow <foo>" messages
(#5812) (DonIsaac)
- b5ad518 linter: Improve diagnostic messages for various lint rules
(#5808) (DonIsaac)
- 858f7af linter: Plugin prefix name for eslint-plugin-node (#5807)
(DonIsaac)
- 737ba1d linter: Fix some cases on ```AssignmentExpression``` for
```unicorn/consistent-function-scoping``` (#5675) (Arian94)
- 148c7a8 linter: Replace bitwise AND (&) with logical AND (&&) in
explici… (#5780) (kaykdm)
- b4ed564 linter/no-unused-vars: Writes to members triggering false
positive (#5744) (Dunqing)
- e9c084a linter/no-unused-vars: False positive when a variable used as
a computed member property (#5722) (Dunqing)

### Performance

- 3725d5d linter: Make all rules share a diagnostics vec (#5806)
(DonIsaac)
- e978567 linter: Shrink size of `DisableDirectives` (#5798) (DonIsaac)
- 1bfa515 linter: Remove redundant clone of diagnostics in context
(#5797) (DonIsaac)
- e413cad linter: Move shared context info to `ContextHost` (#5795)
(DonIsaac)

### Refactor

- 6dd6f7c ast: Change `Comment` struct (#5783) (Boshen)
- 7caae5b codegen: Add `GetSpan` requirement to `Gen` trait (#5772)
(Boshen)
- 026ee6a linter: Decouple module resolution from import plugin (#5829)
(dalaoshu)
- 50834bc linter: Move `override_rule` to `OxlintRules` (#5708)
(DonIsaac)
- a438743 linter: Move `OxlintConfig` to `Oxlintrc` (#5707) (DonIsaac)
- f61e8b5 linter: Impl serde and schemars traits for `LintPlugins`
(#5706) (DonIsaac)
- 20a7861 linter: Shorten `Option` syntax (#5735) (overlookmotel)
- d8b612c oxc_linter: Prefer pass Enum instead of str `no_plus_plus`
(#5730) (IWANABETHATGUY)
- cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants