Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach add_document and add_schema from TestDatabase #237

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

cafca
Copy link
Member

@cafca cafca commented Aug 13, 2022

Refactors these methods as independent helpers as discussed in #141 (comment)

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@cafca cafca linked an issue Aug 13, 2022 that may be closed by this pull request
@cafca cafca requested a review from sandreae August 13, 2022 10:32
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #237 (477a403) into development (c95a789) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 477a403 differs from pull request most recent head c335e53. Consider uploading reports for the commit c335e53 to get more accurate results

@@               Coverage Diff               @@
##           development     #237      +/-   ##
===============================================
- Coverage        94.00%   93.83%   -0.17%     
===============================================
  Files               59       58       -1     
  Lines             4917     4805     -112     
===============================================
- Hits              4622     4509     -113     
- Misses             295      296       +1     
Impacted Files Coverage Δ
aquadoggo/src/db/stores/test_utils/store.rs 92.15% <ø> (-7.85%) ⬇️
aquadoggo/src/db/stores/test_utils/helpers.rs 96.34% <100.00%> (-3.66%) ⬇️
aquadoggo/src/graphql/client/dynamic_query.rs 91.82% <100.00%> (+0.55%) ⬆️
...quadoggo/src/graphql/client/dynamic_types/tests.rs 100.00% <100.00%> (ø)
aquadoggo/src/graphql/client/tests.rs 100.00% <100.00%> (ø)
aquadoggo/src/graphql/client/utils.rs 92.59% <100.00%> (ø)
aquadoggo/src/graphql/schema.rs 92.64% <100.00%> (ø)
aquadoggo/src/node.rs 0.00% <0.00%> (-84.62%) ⬇️
.../src/graphql/client/dynamic_types/document_meta.rs 62.50% <0.00%> (-18.46%) ⬇️
aquadoggo/src/graphql/scalars/seq_num_scalar.rs 88.88% <0.00%> (-8.62%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adzialocha adzialocha changed the title Detach add_document and add_schema from TestDabatase Detach add_document and add_schema from TestDatabase Aug 17, 2022
@adzialocha adzialocha changed the base branch from main to development August 22, 2022 12:10
* development:
  Rename `nextEntryArgs` and `publishEntry` (#232)
  Fix GraphQL responses (#236)
  Friendly names for scalars in GraphQL schema (#231)
  clippy
  Use `DocumentStore` trait from p2panda rs (#249)
  Corrections in e2e test
  Untagged operation format & schema validation (#235)
@adzialocha adzialocha self-requested a review August 22, 2022 14:43
@adzialocha adzialocha merged commit 1745b33 into development Aug 22, 2022
@adzialocha adzialocha deleted the detach-test-helpers branch August 22, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detach add_document and add_schema test helpers from store
2 participants