-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobStore
for retrieving raw blob data from the db
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #484 +/- ##
===============================================
+ Coverage 91.95% 91.97% +0.01%
===============================================
Files 100 101 +1
Lines 15914 16110 +196
===============================================
+ Hits 14634 14817 +183
- Misses 1280 1293 +13
☔ View full report in Codecov by Sentry. |
sandreae
added a commit
that referenced
this pull request
Aug 31, 2023
* Use p2panda-rs version which has blob schema * `SchemaProvider` now has 4 system schema :-) * Update proptests * Implement BlobStore with `get_blob` method * Clippy happy * Fix imports * fmt * Remove some BlobStoreErrors and error tests * Update CHANGELOG * add `get_blob_by_view_id` method * clippy
adzialocha
added a commit
that referenced
this pull request
Sep 8, 2023
* development: Make sure `/tmp` directory does not run out of scope before application ends (#557) Integrate `Bytes` value (#554) Stream blob data in chunks to files to not occupy too much memory (#551) Blobs directory configuration (#549) Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs Build a byte buffer over paginated pieces when assembling blobs (#547) HTTP routes to serve files with correct content type and etag headers (#544) Task for automatic garbage collection of unused documents and views (#500) Refactor tmp blob dir creation after rebase Fix after rebase "blob" materializer task (#493) Add static file server to `http` service (#483) Enable deletion of dangling `document_views` and related `document_view_fields` from db (#491) BlobStore for retrieving raw blob data from the db (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caveat: I'm still on the fence about whether we want to store blobs like this (all pieces as their own document) but I wanted to try out this approach first as a) it fits so smoothly in with our current documents system b) it's easy to do and the api won't really change if we take a different approach to storing blobs anyway. So, this is the minimal-changes approach, and we can iterate from here 👍
Introduces
BlobStore
with one method:get_blob
.Under the hood this:
blob_v1
pieces
fieldThis is done without introducing a new
Blob
type intop2panda-rs
(as was the approach withSchema
, our other system schema type). I actually think this works ok for now, but interested in any thoughts on this.📋 Checklist
CHANGELOG.md