Integrate Bytes value
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #554 +/- ##
===============================================
- Coverage 92.55% 92.45% -0.10%
===============================================
Files 105 106 +1
Lines 17988 18039 +51
===============================================
+ Hits 16648 16678 +30
- Misses 1340 1361 +21
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
adzialocha
reviewed
Sep 7, 2023
| @@ -385,6 +387,7 @@ mod tests { | |||
| ("artist", "David Bowie".into(), None), | |||
| ("title", "Speed Of Life".into(), None), | |||
| ("release_year", 1977.into(), None), | |||
| ("audio", vec![8, 9, 10, 11][..].into(), None), | |||
adzialocha
added a commit
that referenced
this pull request
Sep 8, 2023
* development: Make sure `/tmp` directory does not run out of scope before application ends (#557) Integrate `Bytes` value (#554) Stream blob data in chunks to files to not occupy too much memory (#551) Blobs directory configuration (#549) Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs Build a byte buffer over paginated pieces when assembling blobs (#547) HTTP routes to serve files with correct content type and etag headers (#544) Task for automatic garbage collection of unused documents and views (#500) Refactor tmp blob dir creation after rebase Fix after rebase "blob" materializer task (#493) Add static file server to `http` service (#483) Enable deletion of dangling `document_views` and related `document_view_fields` from db (#491) BlobStore for retrieving raw blob data from the db (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased from #552
Bytesin the database as a hexadecimal string still in theoperation_field_v1"value" columnBLOBbut this would break compatibility with Postgres and in any case we are likely to stream the bytes directly to and from the filesystem in a later optimisationGraphQLapi bytes are represented byHexBytesScalar📋 Checklist
CHANGELOG.md