Task for automatic garbage collection of unused documents and views #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## development #500 +/- ##
============================================
Coverage 92.05% 92.05%
============================================
Files 104 104
Lines 16629 16629
============================================
Hits 15308 15308
Misses 1321 1321 ☔ View full report in Codecov by Sentry. |
|
More PostgreSQL woes.... this time it doesn't like how we do triggers, it wants us to define a function, but SQLite doesn't do functions.... |
sandreae
commented
Aug 15, 2023
sandreae
commented
Aug 15, 2023
sandreae
commented
Aug 15, 2023
sandreae
commented
Aug 15, 2023
This was
linked to
issues
Aug 15, 2023
sandreae
changed the title
adzialocha
changed the title
adzialocha
reviewed
Aug 18, 2023
adzialocha
requested changes
Aug 21, 2023
sandreae
force-pushed
the
garbage-collection
branch
from
02f9cc1
to
4a4bb40
Compare
sandreae
force-pushed
the
garbage-collection
branch
from
4a4bb40
to
2c35f30
Compare
adzialocha
added a commit
that referenced
this pull request
Sep 8, 2023
* development: Make sure `/tmp` directory does not run out of scope before application ends (#557) Integrate `Bytes` value (#554) Stream blob data in chunks to files to not occupy too much memory (#551) Blobs directory configuration (#549) Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs Build a byte buffer over paginated pieces when assembling blobs (#547) HTTP routes to serve files with correct content type and etag headers (#544) Task for automatic garbage collection of unused documents and views (#500) Refactor tmp blob dir creation after rebase Fix after rebase "blob" materializer task (#493) Add static file server to `http` service (#483) Enable deletion of dangling `document_views` and related `document_view_fields` from db (#491) BlobStore for retrieving raw blob data from the db (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this PR is made up of just 10% actual new code and 90% tests.....
Introduces a new "garbage_collection" task to the materializer service. It is concerned with two different connected but discreet functions:
The purging only occurs for blobs, but this functionality could be re-used in the future to handle other kind of "dependent" documents which should only be kept alive when related to by other documents.
One point to note is that no rows are removed from the
logstable as we still need to block off used log ids.Next steps:
📋 Checklist
CHANGELOG.md