Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Improve French Locales #1576

Closed
wants to merge 2 commits into from

Conversation

Lytzeer
Copy link

@Lytzeer Lytzeer commented May 29, 2024

What are the changes?

This add French Locales for the different combat phases and egg hatch.
I also put the German translation that you gave me in my previous PR (battle phase only)

Why am I doing these changes?

To have more of the game translated into French for French players.
I had already made a PR ( #1344 ) but it was closed due to my many errors.
I still continue to translate into French what remains to be translated in the rest of the game

What did change?

I changed different texts in the battle phase (not all)

Screenshots/Videos

image
image
image

How to test the changes?

You just have to set the French language

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Dakurei
Copy link
Collaborator

Dakurei commented May 29, 2024

A large part of it is already done here (#1276) in a cleaner way in relation to the prefix, which can be a suffix depending on the language, in this case as in French, which makes your 2nd screen syntactically wrong

@Lytzeer
Copy link
Author

Lytzeer commented May 29, 2024

Oh sorry, I haven't seen this PR, the PR #1276 version is better

@flx-sta
Copy link
Collaborator

flx-sta commented May 29, 2024

@Lytzeer if you prefer #1276 please close yours by hitting Close pull request
image

Feel free to add your review to #1276

@Lytzeer Lytzeer closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants