Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document more of the BundleGraph class #8711

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Dec 21, 2022

I copied over the not-yet-committed comments from #5347

Co-Authored-By: Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.51s -6.00ms
Cached 338.00ms -5.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 88.00ms -158.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 89.00ms -159.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 88.00ms -160.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 87.00ms -158.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 88.00ms -158.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 88.00ms -157.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 9.91s +214.00ms
Cached 440.00ms -28.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 486.37kb +0.00b 5.32s +333.00ms ⚠️
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 5.31s +332.00ms ⚠️
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 5.31s +332.00ms ⚠️
dist/NotFound.960ab92b.js 429.00b +0.00b 5.31s +332.00ms ⚠️
dist/logo.c5bb83f1.png 246.00b +0.00b 5.32s +332.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.75m -249.00ms
Cached 2.28s -4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.11s +12.00ms
Cached 267.00ms -29.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 10a56a7 into v2 Dec 22, 2022
@mischnic mischnic deleted the mischnic/bundlegraph-doc branch December 22, 2022 14:39
marcins pushed a commit to marcins/parcel that referenced this pull request Jul 14, 2023
* upstream/v2: (33 commits)
  v2.8.3
  Changelog for v2.8.3
  Address bug by updating an asset reference and merge conditions (parcel-bundler#8762)
  Fix CSS order when merging type change bundles (parcel-bundler#8766)
  fixing failing build for contributors on Linux using Node 18 (parcel-bundler#8763)
  Extension: Importers View and separate LSP protocol package (parcel-bundler#8747)
  Bump swc to fix sourcemaps with Windows line endings (parcel-bundler#8756)
  Apply HMR updates in topological order (parcel-bundler#8752)
  Make extension packaging work (parcel-bundler#8730)
  Typed api.storeResult (parcel-bundler#8732)
  Refactor LSP to use vscode-jsonrpc (parcel-bundler#8728)
  Bump swc (parcel-bundler#8742)
  Recursively check reachability when removing asset graphs from bundles in deduplication (parcel-bundler#6004)
  Fix tsc sourcemaps metadata (parcel-bundler#8734)
  Assigning to `this` in CommonJS (parcel-bundler#8737)
  Don't retarget dependencies if a symbol is imported multiple times with different local names (parcel-bundler#8738)
  Add a note about using flow in CONTRIBUTING.md (parcel-bundler#8731)
  filter out title execArgv to workers (parcel-bundler#8719)
  Document more of the BundleGraph class (parcel-bundler#8711)
  Fixed the hmr connection with host 0.0.0.0 (parcel-bundler#7357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants