This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Implement prune only stagnant check mode #5761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will likely be required if we enable stagnant prunning as currently database has way too many entries to be prunned in a single iteration
vstakhov
added
A0-please_review
ordian
reviewed
Jul 6, 2022
ordian
approved these changes
Jul 7, 2022
Co-authored-by: Andronik <write@reusable.software>
ordian
reviewed
Jul 7, 2022
Co-authored-by: Andronik <write@reusable.software>
rphmeier
approved these changes
Jul 9, 2022
|
bot merge |
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Jul 12, 2022
…systems * master: (39 commits) Implement prune only stagnant check mode (#5761) Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769) Update release-99_bot.yml (#5764) Version bump to v0.9.26/9260 (#5755) Rename `extra_constant` (#5749) Bump wasmtime from 0.38.0 to 0.38.1 (#5741) Several small fixes to the templates of the release notes (#5756) Backports from 0.9.25 (#5754) Remove bridges subtree (#5752) [Zombienet] test deregister validator (#5718) Fix regexp to find the repo name (#5751) Limit stagnant checks to a certain amount of entries (#5742) fix(staking miner): check latest state in solution (#5744) staking-miner: CLI flag delay solution x secs (#5734) backport minimum weight to fee to master (#5739) Bump quote from 1.0.19 to 1.0.20 (#5736) zombienet: try to fix parachains upgrade test (#5724) Update dependencies (companion for substrate#11722) (#5731) Update metric name and doc (#5716) Bump reqwest from 0.11.10 to 0.11.11 (#5732) ...
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Limit number of elements loaded from the stagnant key This will likely be required if we enable stagnant prunning as currently database has way too many entries to be prunned in a single iteration * Fmt run * Slightly improve logging * Some more debug nits * Fmt pass * Add stagnant prunning delay * Enable stagnant check worker * Implement stagnant pruning without stagnant checks * Update node/core/chain-selection/src/tree.rs Co-authored-by: Andronik <write@reusable.software> * Apply suggestions from code review Co-authored-by: Andronik <write@reusable.software> Co-authored-by: Andronik <write@reusable.software>
ordian
added a commit
that referenced
this pull request
Jul 22, 2022
* master: westend xcm: collectives parachain is trusted teleporter (#5798) Cleanup light client leftovers (#5794) Fix benchmarking tests (#5791) allow re-use and avoid compiling kusama parachain code (#5792) Introduce async runtime calling trait for runtime-api subsystem (#5782) add `Extrinsic Ordering` check that runs against a local reference node (#5790) Co #11456: Expose `benchmark extrinsic` command (#5620) `staking-miner`: Add handling of `SIGTERM`, `SIGKILL`, `SIGQUIT` and `SIGINT` (#5780) Zombienet: paritydb test (#5310) Fix Typo (#5766) Fix Core Version display in the release notes (#5781) companion for new pools reward scheme (#5757) fix disable-runtime-api feature flag (#5773) split NetworkBridge into two subsystems (#5616) Implement prune only stagnant check mode (#5761)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we are not sure about interaction between finality lag and stagnant checks. This PR tries to introduce a trade-off where stagnant entries are just cleaned after some long period of time (25 hours) without the actual checks of stagnant blocks. This allows to keep database clean from stagnant entries that are otherwise kept indefinitely when stagnant checks are disabled. On the other hand, this mode does not interfere with finality and has quite a large margin to prevent active entries to be removed.