This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce async runtime calling trait for runtime-api subsystem #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
A0-please_review
|
Any reason why |
|
Good point. I was initially under the impression that this would not be a big problem since runtime-api subsystem already depends on But still |
davxy
approved these changes
Jul 15, 2022
Co-authored-by: Davide Galassi <davxy@datawok.net>
bkchr
approved these changes
Jul 16, 2022
| // === AuthorityDiscovery API === | ||
|
|
||
| /// Retrieve authority identifiers of the current and next authority set. | ||
| async fn authorities( |
There was a problem hiding this comment.
Maybe rename it to authority_discovery_authorities or something else? Otherwise the name is really generic.
There was a problem hiding this comment.
I think here I would prefer to keep it this way. I mirrored the naming of the runtime methods exactly, same for methods like validators. I think in the context of this runtime client, it should be pretty clear were they are coming from.
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
ordian
reviewed
Jul 18, 2022
koute
approved these changes
Jul 19, 2022
|
bot merge |
ordian
added a commit
that referenced
this pull request
Jul 22, 2022
* master: westend xcm: collectives parachain is trusted teleporter (#5798) Cleanup light client leftovers (#5794) Fix benchmarking tests (#5791) allow re-use and avoid compiling kusama parachain code (#5792) Introduce async runtime calling trait for runtime-api subsystem (#5782) add `Extrinsic Ordering` check that runs against a local reference node (#5790) Co #11456: Expose `benchmark extrinsic` command (#5620) `staking-miner`: Add handling of `SIGTERM`, `SIGKILL`, `SIGQUIT` and `SIGINT` (#5780) Zombienet: paritydb test (#5310) Fix Typo (#5766) Fix Core Version display in the release notes (#5781) companion for new pools reward scheme (#5757) fix disable-runtime-api feature flag (#5773) split NetworkBridge into two subsystems (#5616) Implement prune only stagnant check mode (#5761)
ordian
added a commit
that referenced
this pull request
Jul 28, 2022
* master: (37 commits) Backport crate version bumps to 0.9.27 (#5826) Fix GHA (#5825) [ci] Add timeout to benchmark jobs (#5822) Parachains db column "migration" (#5797) Companion for #11831 (#5784) [ci] Return production image (#5818) add migration for staking v10 (#5817) Prepare for rust 1.62.1 (#5811) Bump strum to 0.24.1 (#5816) Bump substrate (#5814) Add missing trigger wildcards for some CI workflows (#5812) malus: add `finality_delay` cli flag (#5770) [ci] publish parachain-implementers-guide (#5806) westend xcm: collectives parachain is trusted teleporter (#5798) Cleanup light client leftovers (#5794) Fix benchmarking tests (#5791) allow re-use and avoid compiling kusama parachain code (#5792) Introduce async runtime calling trait for runtime-api subsystem (#5782) add `Extrinsic Ordering` check that runs against a local reference node (#5790) Co #11456: Expose `benchmark extrinsic` command (#5620) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for paritytech/cumulus#989 (split for more manageable reviews).
As explained in paritytech/cumulus#989, we want to run an overseer with only a few subsystems in the collator node. All communication to the relay chain happens via our RPC.
In this PR, I introduce a new trait,
RuntimeApiSubsystemClient. This trait exposes all the runtime methods we need in the subsystem and can be implemented by an RPC-Client (Provided by a future PR). Currently, implementation is provided for the local runtime.cumulus companion: paritytech/cumulus#1447